From dc7cddfbc9ec3b32a23aeb0a5bd3ab0a079eb1bc Mon Sep 17 00:00:00 2001 From: MarioJGMsoft Date: Mon, 16 Dec 2024 22:31:46 +0000 Subject: [PATCH 1/5] refactor: Deleted enableGroupedBatching from IContainerRuntimeOptions --- .../api-report/container-runtime.legacy.alpha.api.md | 2 -- .../runtime/container-runtime/src/containerRuntime.ts | 10 ---------- 2 files changed, 12 deletions(-) diff --git a/packages/runtime/container-runtime/api-report/container-runtime.legacy.alpha.api.md b/packages/runtime/container-runtime/api-report/container-runtime.legacy.alpha.api.md index 4036d7fe5f8e..41828e13dbb3 100644 --- a/packages/runtime/container-runtime/api-report/container-runtime.legacy.alpha.api.md +++ b/packages/runtime/container-runtime/api-report/container-runtime.legacy.alpha.api.md @@ -340,8 +340,6 @@ export interface IContainerRuntimeMetadata extends ICreateContainerMetadata, IGC export interface IContainerRuntimeOptions { readonly chunkSizeInBytes?: number; readonly compressionOptions?: ICompressionRuntimeOptions; - // @deprecated - readonly enableGroupedBatching?: boolean; readonly enableRuntimeIdCompressor?: IdCompressorMode; readonly explicitSchemaControl?: boolean; // @deprecated diff --git a/packages/runtime/container-runtime/src/containerRuntime.ts b/packages/runtime/container-runtime/src/containerRuntime.ts index b71916f96ce9..3f2d3517dccc 100644 --- a/packages/runtime/container-runtime/src/containerRuntime.ts +++ b/packages/runtime/container-runtime/src/containerRuntime.ts @@ -514,16 +514,6 @@ export interface IContainerRuntimeOptions { */ readonly enableRuntimeIdCompressor?: IdCompressorMode; - /** - * If enabled, the runtime will group messages within a batch into a single - * message to be sent to the service. - * The grouping and ungrouping of such messages is handled by the "OpGroupingManager". - * - * By default, the feature is enabled. - * @deprecated The ability to disable Grouped Batching is deprecated and will be removed in v2.20.0. This feature is required for the proper functioning of the Fluid Framework. - */ - readonly enableGroupedBatching?: boolean; - /** * When this property is set to true, it requires runtime to control is document schema properly through ops * The benefit of this mode is that clients who do not understand schema will fail in predictable way, with predictable message, From 4232ed5241ab1593d97799724686fc07d2e8b3cd Mon Sep 17 00:00:00 2001 From: MarioJGMsoft Date: Tue, 17 Dec 2024 20:55:23 +0000 Subject: [PATCH 2/5] docs: added changeset --- .changeset/quiet-days-carry.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .changeset/quiet-days-carry.md diff --git a/.changeset/quiet-days-carry.md b/.changeset/quiet-days-carry.md new file mode 100644 index 000000000000..6fe9e78b527e --- /dev/null +++ b/.changeset/quiet-days-carry.md @@ -0,0 +1,10 @@ +--- +"@fluidframework/container-runtime": minor +--- +--- +"section": legacy +--- + +IContainerRuntimeOptinos.enableGroupedBatching has been removed + +This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed. \ No newline at end of file From 6a403b935e54e2b14f317f7b2f1dc19cfe3419f3 Mon Sep 17 00:00:00 2001 From: MarioJGMsoft Date: Mon, 6 Jan 2025 23:29:00 +0000 Subject: [PATCH 3/5] docs: updated changeset to make changes clearer --- .changeset/quiet-days-carry.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/quiet-days-carry.md b/.changeset/quiet-days-carry.md index 6fe9e78b527e..f69af0919464 100644 --- a/.changeset/quiet-days-carry.md +++ b/.changeset/quiet-days-carry.md @@ -5,6 +5,6 @@ "section": legacy --- -IContainerRuntimeOptinos.enableGroupedBatching has been removed +Grouped batching is enabled by default and IContainerRuntimeOptinos.enableGroupedBatching has been removed -This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed. \ No newline at end of file +This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed and it will always be enabled by default. From 277df76888a13f76eda518164e546a933f04be3e Mon Sep 17 00:00:00 2001 From: MarioJGMsoft Date: Tue, 7 Jan 2025 17:33:56 +0000 Subject: [PATCH 4/5] docs: Fixed typo --- .changeset/quiet-days-carry.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/quiet-days-carry.md b/.changeset/quiet-days-carry.md index f69af0919464..06ea0709a9b1 100644 --- a/.changeset/quiet-days-carry.md +++ b/.changeset/quiet-days-carry.md @@ -5,6 +5,6 @@ "section": legacy --- -Grouped batching is enabled by default and IContainerRuntimeOptinos.enableGroupedBatching has been removed +Grouped batching is enabled by default and IContainerRuntimeOptions.enableGroupedBatching has been removed This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed and it will always be enabled by default. From bb002be2d6084018fa4617e489e4390e0f2525d5 Mon Sep 17 00:00:00 2001 From: MarioJGMsoft Date: Tue, 7 Jan 2025 18:47:24 +0000 Subject: [PATCH 5/5] docs: Applied changes to changeset based on comments --- .changeset/quiet-days-carry.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.changeset/quiet-days-carry.md b/.changeset/quiet-days-carry.md index 06ea0709a9b1..b5565dda0ca5 100644 --- a/.changeset/quiet-days-carry.md +++ b/.changeset/quiet-days-carry.md @@ -5,6 +5,8 @@ "section": legacy --- -Grouped batching is enabled by default and IContainerRuntimeOptions.enableGroupedBatching has been removed +Grouped batching is enabled by default and cannot be disabled -This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed and it will always be enabled by default. +The Grouped Batching feature in the container runtime has stabilized and is now enabled by default. + +The `IContainerRuntimeOptions.enableGroupedBatching` option, which allowed an application to disable grouped batching, has been removed. Grouped Batching is now considered a core part of the container runtime, and as such can no longer be disabled.