[BREAK IN 2.20.0] Remove support for Batch Grouping configuration #23336
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
MarioJGMsoft
requested review from
a team,
pragya91,
markfields,
jatgarg,
tyler-cai-microsoft,
kian-thompson and
rajatch-ff
and removed request for
a team
tylerbutler
reviewed
Jan 7, 2025
.changeset/quiet-days-carry.md
Outdated
| "section": legacy | ||
| --- | ||
|
|
||
| Grouped batching is enabled by default and IContainerRuntimeOptions.enableGroupedBatching has been removed |
There was a problem hiding this comment.
Suggested change
| Grouped batching is enabled by default and IContainerRuntimeOptions.enableGroupedBatching has been removed | |
| Grouped batching is now enabled by default and cannot be disabled |
There was a problem hiding this comment.
Applied changes
.changeset/quiet-days-carry.md
Outdated
|
|
||
| Grouped batching is enabled by default and IContainerRuntimeOptions.enableGroupedBatching has been removed | ||
|
|
||
| This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed and it will always be enabled by default. |
There was a problem hiding this comment.
Suggested change
| This option allowed an application to disable grouped batching. But now we no longer want users to be able to turn it on or off, so this option can be removed and it will always be enabled by default. | |
| The Grouped Batching feature in the container runtime has stabilized and is now enabled by default. | |
| The `IContainerRuntimeOptions.enableGroupedBatching` option, which allowed an application to disable grouped batching, has been removed. Grouped Batching is now considered a core part of the container runtime, and as such can no longer be disabled. |
There was a problem hiding this comment.
Applied changes
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After discussing the work in task #8124, we concluded that it was best to make Batch Grouping dependent on Batch Compression.
This means that we need to remove the ability for users to configure Batch Grouping.
Acceptance Criteria:
Fluid users can no longer configure Batch Grouping.
Execution Plan:
Remove Batch Grouping configuration from containerRuntime.ts and update it to the IContainerRuntimeOptionsInternal.enableGroupedBatching version.
Breaking Changes
This is a breaking change but IContainerRuntimeOptionsInternal has been created to still be compatible with different versions of FF.
Reviewer Guidance
Please let me know if you think there's anything missing that I should add to this PR or anything related to it
Fixes AB#26249