Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

somd.rst7 gets wrongly numbered if started from partial set of ensemble_equilibration directories #35

Closed
fjclark opened this issue Feb 21, 2025 · 1 comment · Fixed by #36
Assignees

Comments

@fjclark
Copy link
Collaborator

fjclark commented Feb 21, 2025

If starting with e.g. 3 complete ensemble_equilibration directories (and all pkl files etc deleted), then running a calculation with e.g. 5 repeats, the 4th and 5th ensemble_equilibration somd.rst7 files will have incorrectly numbered somd.rst7 files (e.g. somd_1.rst7) rather than (somd_4.rst7).

Thanks @silviamenin for finding.

I have fixed this and will create a PR shortly.

@fjclark fjclark self-assigned this Feb 21, 2025
@fjclark fjclark mentioned this issue Feb 21, 2025
1 task
@Roy-Haolin-Du
Copy link
Contributor

Similarly, if you start with 3 completed runs and then run 5 repeats (e.g., the 4th and 5th), we can use run(run_nos = <>). However, since run_nos = list(range(1, self.ensemble_size + 1)), someone might run into this issue in the future. I will take care of it when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants