Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queation about the implementation #29

Open
wuchichung opened this issue Nov 10, 2017 · 0 comments
Open

queation about the implementation #29

wuchichung opened this issue Nov 10, 2017 · 0 comments

Comments

@wuchichung
Copy link

wuchichung commented Nov 10, 2017

                ## This case will only happend if subset[j] has already contains partAs[i]
                ## if subset[j] does not have partBs[i] , add partBs[i] to subset[j]
                ## FIXME what if subset[j] already contains partBs[i]
                if (subset[j][indexB] != partBs[i]):
                    subset[j][indexB]  = partBs[i]
                    subset[j][-1] += 1
                    subset[j][-2] += candidate[partBs[i].astype(int), 2] + connection_all[k][i][2]

after i check the mapIdx, there will be a problem ,as joint 6 was put into the subset by [2,6] in the 2nd iteration, [16,18] will put 18 in the subset in the 17th iteration, however, [6,18] may put another 18 joint into subset at the 19th iteration. From my understanding, [6,18] and [16,18] connections are independent of each other, then, one subset may have two different joint 18.

i think it will be great if we can make sure each subset will not have more than 1 each joint for some application.

to do that, we can compare two different joint 18's score to decide which one to put into the subset.

how do you think about that ? and anyway, it is a great work, i have read the whole implementation, it is great. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant