Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

your lib seems sketchy #6

Open
movie99 opened this issue Aug 7, 2020 · 3 comments
Open

your lib seems sketchy #6

movie99 opened this issue Aug 7, 2020 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@movie99
Copy link

movie99 commented Aug 7, 2020

when running your code it was downloading vurtualenv and other unnecessary packages.

@Jah-On
Copy link

Jah-On commented Aug 18, 2020

The code is yours to look at, I didn't see any virtualenv references.

@mherkazandjian
Copy link
Owner

i think the virtualenv installation is triggered by this
https://github.com/mherkazandjian/fastgrab/blob/master/Pipfile#L9
that is needed for development.
virtualenv is not used anywhere in the code though, it is basically used by pipenv in case you want to develop
the package itself.
(sorry for the late reply, just cleaning up the issues)

@mherkazandjian mherkazandjian self-assigned this Aug 20, 2023
@mherkazandjian mherkazandjian added the question Further information is requested label Aug 20, 2023
@Arcitec
Copy link

Arcitec commented May 29, 2024

The code is short enough that I read through it in 10 minutes. It's completely clean.

Thanks for creating this fast little library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants