Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.go support more console definitions #168

Open
majst01 opened this issue Dec 21, 2022 · 3 comments
Open

install.go support more console definitions #168

majst01 opened this issue Dec 21, 2022 · 3 comments

Comments

@majst01
Copy link
Contributor

majst01 commented Dec 21, 2022

if more than one console was configured as metal-kernel cmdline, install-go fails with:

Serial console could no be split into host and port 
@Gerrit91
Copy link
Contributor

Have some questions.

  • How to separate multiple consoles in the console string? Or do we need to migrate to a string slice (breaking)?
  • Do we want to require a serial console (ttyS) in the kernel string for grub or can it also go without? The check that the given console is of type serial ttyS should already be done in the current implementation, I guess?

@majst01
Copy link
Contributor Author

majst01 commented Jan 10, 2023

Have some questions.

  • How to separate multiple consoles in the console string? Or do we need to migrate to a string slice (breaking)?
  • Do we want to require a serial console (ttyS) in the kernel string for grub or can it also go without? The check that the given console is of type serial ttyS should already be done in the current implementation, I guess?

I think the simplest approach would be to configure grub to only spit out to ttyS, but what to do if someone defines more than one ttyS

@Gerrit91
Copy link
Contributor

According to the kernel docs, defining multiple serial consoles is not valid:

Note that you can only define one console per device type (serial, video).

(https://docs.kernel.org/admin-guide/serial-console.html)

However, if we allow multiple console, we will also have a broken kernel commandline:

fmt.Sprintf("console=%s", i.config.Console), <-- this has to become a repeated arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants