Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for getMeshSyncStatus #647

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

palSagnik
Copy link
Contributor

@palSagnik palSagnik commented Jan 21, 2025

Description

This PR fixes Meshery Operator Controller checks failing

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

palSagnik and others added 2 commits January 21, 2025 15:49
@palSagnik
Copy link
Contributor Author

The frontend logic for MeshSync Ad Hoc Connectivity Test was checking for Connected string but the backend was returning Deployed or Deploying which are not the same.

  • ✅ MeshSync chip
  • ❌ Meshery Broker chip

Will fix in next PR as it needs more trouble shooting

@leecalcote
Copy link
Member

leecalcote commented Jan 21, 2025

The frontend logic for MeshSync Ad Hoc Connectivity Test was checking for Connected string but the backend was returning Deployed or Deploying which are not the same.

  • ✅ MeshSync chip
  • ❌ Meshery Broker chip

Will fix in next PR as it needs more trouble shooting

Is it the frontend that needs to change? Verify against the Meshery Docs page on troubleshooting these connections, please, @palSagnik.

@palSagnik
Copy link
Contributor Author

According to the troubleshooting specs document, the front-end is using the correct terms, there needs to be a change in the backend to fix the ad-hoc connectivity test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meshery Operator Controller checks failing
2 participants