Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderResult should have diagram type #5117

Open
sidharthv96 opened this issue Dec 6, 2023 · 0 comments · Fixed by #5118
Open

RenderResult should have diagram type #5117

sidharthv96 opened this issue Dec 6, 2023 · 0 comments · Fixed by #5118
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@sidharthv96
Copy link
Member

Currently renderResult has svg and bindFunctions. But a new field diagramType should also be added.
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Dec 6, 2023
sidharthv96 added a commit that referenced this issue Dec 6, 2023
@sidharthv96
feat: Add diagramType to RenderResult and ParseResult #5117
c3c7ccd
@sidharthv96 sidharthv96 mentioned this issue Dec 6, 2023
Merged
4 tasks
@sidharthv96 sidharthv96 linked a pull request Dec 6, 2023 that will close this issue
feat: Add diagramType to RenderResult and ParseResult #5118
Merged
4 tasks
sidharthv96 added a commit that referenced this issue Jan 19, 2024
@sidharthv96
Merge branch 'next' of github.com:mermaid-js/mermaid into combineImages
6c61d59 
* 'next' of github.com:mermaid-js/mermaid: (83 commits)
  Fix merge error
  Update packages/mermaid/src/diagrams/flowchart/flowDb.ts
  chore: Add docs
  chore: Add docs
  Update docs
  Update packages/mermaid/src/docs/config/usage.md
  chore: Fix import.meta.vitest warnings
  chore: Overload parse type to be more specific.
  Remove default properties before generating the config types
  refactor: Address review comments
  test: Update tests
  refactor: Change return type to retain partial backwards compatibility.
  feat: Add diagramType to RenderResult and ParseResult #5117
  chore: Cleanup types
  chore: Remove unused file
  Convert flowDb.spec.js
  fix: Flatten Nodelist
  chore: Fix bindFunctions type
  chore: Separate types
  refactor: Convert flowDB to TS
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add diagramType to RenderResult and ParseResult mermaid-js/mermaid
1 participant
@sidharthv96