Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Ars Nouveau's Skyweave as sky for solar panels #733

Open
LawOfSynergy opened this issue Dec 19, 2024 · 2 comments
Open

Treat Ars Nouveau's Skyweave as sky for solar panels #733

LawOfSynergy opened this issue Dec 19, 2024 · 2 comments

Comments

@LawOfSynergy
Copy link

LawOfSynergy commented Dec 19, 2024

Describe the feature you'd like

I would like to see a whitelist in the generators config for blocks that are sky or that simulate sky such as the skyweave block from ars nouveau.

Solar panels should work properly as long as there is unbroken Line-Of-Sight to sky or a whitelisted "sky" block

Describe alternatives you've considered

The only alternative I can think of would be to not have such a feature, meaning solar panels can only work aboveground as is the current behavior.

Edit: An alternative mechanism would be to introduce a tag that can be applied to items that are to be treated as sky, instead of specifying a config based whitelist. These two solutions are not mutually exclusive.

Additional context

No response

@pupnewfster
Copy link
Member

I am unsure about this. Namely because we just use vanilla's BlockAndTintGetter#canSeeSky method. So part of me feels like if they want to make it so that their block is treated as sky by other mods, they should adjust how that method works to return true as appropriate.

@LawOfSynergy
Copy link
Author

LawOfSynergy commented Feb 25, 2025

In that case I can open a ticket on their github and link it here. However that does limit people's ability to tweak via datapack, such as to use "radiation sources" or whatever nonsense makes sense to the pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants