Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior with rmWhiteSpace #260

Open
manu-st opened this issue May 23, 2017 · 2 comments
Open

Strange behavior with rmWhiteSpace #260

manu-st opened this issue May 23, 2017 · 2 comments
Labels
bug Something isn't working

Comments

@manu-st
Copy link

manu-st commented May 23, 2017

If I enable rmWhiteSpace, then for some of my .ejs files, it concatenates 2 consecutive lines into one. So far I only noticed this with .ejs files containing javascript code such as the following:

        $form.find('.submit').prop('disabled', false);  // Re-enable submission
    } else {

it would generate

        $form.find('.submit').prop('disabled', false);  // Re-enable submission} else {

which of course doesn't mean the same thing.

Is this expected and this is a misunderstanding of what rmWhiteSpace is supposed to do, or is it a bug?

Thanks!

@RyanZim
Copy link
Collaborator

RyanZim commented May 23, 2017

I'd call that a bug. Are you using CRLF line endings?

@RyanZim RyanZim added the bug Something isn't working label May 23, 2017
@manu-st
Copy link
Author

manu-st commented May 23, 2017

I'm definitely using CRLF on my test machine, but the server is running Linux and files only contain LF and I have the same behavior. The file where I have the problem is used via an EJS include in case it matters (the old way <% include ../../file.ejs %>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants