git hub commit #11
-
|
Hello Matt, As per your suggestion I forked kodi_panel and proposed a (simple) pull request. (update of the frame buffer script with direction regarding the blinking cursor) Have I done it correctly? Other question, I have a lot of ideas for new features, and want to make a list of it. |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
|
You're most recent Pull Request (adding to the codec lookup table) seemed to work fine. Afterwards, though, I think you executed a merge from this repository back to your branch (rather than to the master branch of your fork). Since a Pull Request existed on that branch, github took the update as a reason to re-open the Pull Request. I think the flows built into github like to enforce the practice of deleting branches once they have "served their purpose". (There are several different schools of thought regarding how best to make use of branches. I don't have too much of an opinion on them... yet.)
The Discussion feature is a relatively new addition to github. Seems like it would be a nice spot for such a list, provided we get some additional readers! I think I would prefer a To Do list in that form, leaving Issues for actual bugs that people have encountered. Think this discussion forum will work? Cheers! |
Beta Was this translation helpful? Give feedback.
-
Looks like the Discussion board has an "Ideas" label / category. That could be a good spot to populate the list. I don't know how many of the readers on the CE Forum thread also have github accounts. We could potentially migrate discussion over here, if there's a critical mass of people. |
Beta Was this translation helpful? Give feedback.
-
|
If we are just two people writing it does not make a lot of sense to do it github. But I think I will populate the "Ideas" label / category to see if it work as a todo list. I am not familiar with IT tools in general (I am a mechanical engineer with virtually no background in coding) but I find the github interface confusing and un-intuitive (even if it is a powerful tool). Regarding my commit for the codec table, I put it in the "my config" branch, then cherry-pick it to my "pull request" branch and then pull requested it to your master branch. I am not sur if it is the right way to do. In the next few days I will commit some change to "my config" branch (special treatement for some info label, PVR progress bar etc if you find some commit interesting, I will try to pull them to you using different method to see the better one to use. |
Beta Was this translation helpful? Give feedback.
-
|
If you're getting the hang of github, @nico1080, could I have you mark this question as "Answered"? Some resources, if you haven't already found them. I should likely read through the second one myself. :) |
Beta Was this translation helpful? Give feedback.
Looks like the Discussion board has an "Ideas" label / category. That could be a good spot to populate the list.
I don't know how many of the readers on the CE Forum thread also have github accounts. We could potentially migrate discussion over here, if there's a critical mass of people.