add 'save password' option

[igroglaz]

I stream (make live video) and can't type in passwords while play. Please add save pass option

[matoom]

I don't know about this. To be honest the security of SF protocol is debatable at best but storing passwords raises security concerns i don't want to deal with.
The backend does not support any kind of extra security features and the passwords are encrypted for session only. The best option i have is to obscure them before storing in a plain ini file but as the source code is readily available here on github even obscuring is kind of pointless. I don't like the idea of having users hit the "store password" checkbox with an illusion of security.
Right now i don't know how or if or when i will add this feature but meanwhile i can offer you a workaround.

If you're comfortable with storing plain text passwords and you have Ruby installed, you can make a script:

• create file in scripts folder:
  connect.rb
• insert this line of code (input your account details):
  Client::connect_prime("char_name", "account_name", "password")
• run:
  .connect

[hennii]

@matoom When I run this script, nothing happens -- should I be seeing the game stream in the client window after this?

[matoom]

I have a f2p account that i use for testing, try this:

echo Client::connect_prime("Kiborkieyt", "ttest21", "qqq12345")

This is what it looks like:

If echo gives you anything other than 0 there's something wrong. It could be something to do with your character info, maybe it doesn't recognize your ruby installation, maybe a bug etc. Debug, error or auth log might have some info.

[hennii]

@matoom Ah, thanks - yes getting a 1 response every time, nothing in the debug.log or error.log or auth.log 🤔 Not a biggie, was just really kinda curious about that Client.connect method from the scripting side of things.

[hennii]

@matoom Side observation, most of the methods in the Client documentation say @return [int] 1 on success; 0 on fail but sounds like it should be the inverse re: success status

[hennii]

@matoom Ah I figure it out -- the Client.connect method doesn't pass the new lich argument required by the api --

frostbite/gui/scriptapiserver.cpp

Lines 173 to 183 in 23dd2f3

	} else if(line.startsWith("CLIENT")) {
	ApiRequest request = parseRequest(line.mid(6).trimmed());
	if(request.name == "CONNECT") {
	QStringList args = request.args;
	if(args.size() < 7) {
	this->write(socket, tr("1\\0"));
	} else {
	tcpClient->connectApi(args.at(0), args.at(1), args.at(2), args.at(3),
	args.at(4), args.at(5), TextUtils::toBool(args.at(6)));
	this->write(socket, tr("0\\0"));
	}

. When I add &FALSE to the end of the CLIENT CONNECT? socket command it works.

UPDATE:

So it looks like you DO have the ruby scripts updated with the release -- the real issue seems to be that the download OSX dmg does not have the updated scripts: https://github.com/matoom/frostbite/releases/tag/v1.9.6-beta

[matoom]

Thanks, you're right. I forgot to update the release files last time i changed the api.

It's not only for osx but all releases are affected.

Edit: i updated it already but i keep a separate set of files for release deployment

https://github.com/matoom/frostbite/blob/master/deploy/common/scripts/lib/models.rb

I need to fix the latest releases.