The order grid page breaks and gives an error.

[bhavyamodi29]

Preconditions

Magento Version : 2.4.6-p2
Module Version : 1.1.1

Description

When we order a product which has pipe symbol ( “ | ” ) in its SKU , then we try to visit the order grid page , it shows an error as shown in screenshot-1.

Screenshot-1

Steps To Reproduce

1. Clone clean shop.
2. Install “MarkShust_OrderGrid” module.
3. Go to the Backend->Catalog->Products.
4. Create any product with the pipe symbol ( “ | ” ) in its SKU ( e.g. SKU = Test | Product).
5. Visit frontend , then order that product.
6. Go to the Backend->Sales->Orders.

Expected Result

When we try to visit the order grid page , it should display product’s details in the Order Items column on the order grid page as shown in screenshot-2.

Screenshot-2

Actual Result

When we try to visit the order grid page , it shows an error as shown in screenshot-1.

Additional Information

The issue arises due to the use of the pipe symbol ( “ | ” ) as a delimiter in the explode function , which separates the SKU , Quantity , and Product Name , as shown in screenshot-3 . Consider using a different delimiter that is unlikely to appear in SKUs , such as a semicolon.

File Name

markshust/magento2-module-ordergrid/Model/ResourceModel/Order/Grid/Collection.php

Screenshot-3

[erfanimani]

I have come across this issue a few times as well, but never ended up investigating it.

The pipe comes from an SQL concat function, I don't think changing it to a semicolon is a good idea — someone somewhere will run into the same problem. Because the pipe is used purely internal, instead it could perhaps be changed to something like {ordergrid_separator}.

[markshust]

I think it makes sense for you to be able to define the delimiter from the admin. Will this work? I don't think there ever will be a single character which works for everyone.

[erfanimani]

Hi @markshust, what do you think of my previous comment? From what I understand it doesn't need to be a single character (in which case there would be a string of characters that would work for everyone).

I don't think we should make the module more complex and get people to configure the module when it should be plug and play.

[kasperth]

@markshust I agree with @erfanimani on his approach. Keeping it it simple as possible.

[markshust]

Ah I don't know what I was thinking. I agree.

[kasperth]

@markshust When do you reckon looking into this? My colleague has en open PR with a possible solution.

[Nichollas96]

Hello, any updates on this topic?

[markshust]

Hi there,

Sorry, I didn't see or was notified of the PR. Here's a link to it for reference: #16

I'll try to check this out soon.