Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Pelias parsing tests layer #282

Open
msmollin opened this issue Apr 21, 2017 · 1 comment
Open

Improve Pelias parsing tests layer #282

msmollin opened this issue Apr 21, 2017 · 1 comment

Comments

@msmollin
Copy link
Member

We currently have a spartan parsing layer in the
https://github.com/mapzen/ios/blob/master/src/PeliasMapkitExtensions.swift#L123

It's functional but I think we could improve upon it, especially in the testing layer. Given Swift 4 recently merged in support for multi-line String support, it should make JSON strings far easier to work with for building mock JSON fixtures in the future. But for now we could add some better tests just in general.
@msmollin msmollin changed the title Improve Pelias parsing layer Improve Pelias parsing tests layer Jun 14, 2017
@msmollin
Copy link
Member Author

pelias/pelias-ios-sdk#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msmollin