Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertion checks for API key usage #259

Open
msmollin opened this issue Apr 11, 2017 · 5 comments
Open

Add assertion checks for API key usage #259

msmollin opened this issue Apr 11, 2017 · 5 comments
Assignees

Comments

@msmollin
Copy link
Member

We should be more aggressive about checking for API key usage in the SDK and utilize something like Cocoa's assert() to avoid assertions being compiled into production code.

@msmollin msmollin added the Next label May 2, 2017
@msmollin
Copy link
Member Author

msmollin commented May 2, 2017

@sarahlensing i think this is done now?

@msmollin
Copy link
Member Author

msmollin commented May 2, 2017

Or did we only add this to the sample app?

@sarahsnow1
Copy link
Member

We only added it to the sample app so we should keep this open and update MapzenSearch, etc.

@msmollin msmollin added in progress and removed Next labels May 11, 2017
@msmollin msmollin self-assigned this May 11, 2017
@msmollin
Copy link
Member Author

Looked at this a little bit and we do kinda already check for this, but just in MZMapViewController https://github.com/mapzen/ios/blob/master/MapzenSDK/MZMapViewController.swift#L1082

And it throws, it doesn't assert the api key missing. Since I can't change that API do you think I should just add an assert into that? Or should I have the other places throw as well?

@msmollin
Copy link
Member Author

After discussion we're going to make this assert and change the call to not throw anymore and deprecate all the loadStyle* functions and create new ones that no longer throw as well. We'll release this as part of 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants