Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localizable.strings #187

Open
sarahsnow1 opened this issue Mar 1, 2017 · 0 comments
Open

Add Localizable.strings #187

sarahsnow1 opened this issue Mar 1, 2017 · 0 comments
Milestone

Comments

@sarahsnow1
Copy link
Member

sarahsnow1 commented Mar 1, 2017

We should support localized strings and make sure they are imported into client applications using Cocoapods

Updating the .podspec file to include:

cs.ios.resource_bundle = { 'MapzenSdk' => 'localization/*' }

Properly brings in all .lproj/ and files into a client application however localized strings don't seem to be a part of either the main bundle or the mapzen framework bundle:

var attribution = NSLocalizedString("attribution", comment: "Mapzen Attribution")
    if attribution == "attribution" {
      let bundles = Bundle.allFrameworks.filter({ (bundle) -> Bool in
        return bundle.bundlePath.contains("Mapzen")
      })
      let bundle = bundles.first
      if bundle != nil {
        attribution = NSLocalizedString("attribution", tableName: "Localizable.strings", bundle: bundle!, value: "value", comment: "Mapzen Attribution")
      }
    }
@ecgreb ecgreb added the launch label Mar 8, 2017
@ecgreb ecgreb added this to the launch milestone Mar 8, 2017
@ecgreb ecgreb removed the launch label Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants