Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simple protocol fee hook #89

Merged
merged 29 commits into from
Jan 23, 2024
Merged

Implement simple protocol fee hook #89

merged 29 commits into from
Jan 23, 2024

Conversation

yorhodes
Copy link
Contributor

@yorhodes yorhodes commented Jan 16, 2024 •
edited
Loading

This has a few PRs merged into it ...
hyperlane-xyz#6

@yorhodes yorhodes changed the title Merge pull request #81 from many-things/develop Implement simple protocol fee hook Jan 16, 2024
nambrot
nambrot reviewed Jan 16, 2024
View reviewed changes
@yorhodes yorhodes marked this pull request as ready for review January 16, 2024 21:24
@byeongsu-hong byeongsu-hong self-requested a review January 17, 2024 04:00
byeongsu-hong
byeongsu-hong requested changes Jan 17, 2024
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024 •
edited
Loading

Codecov Report

Attention: 1130 lines in your changes are missing coverage. Please review.

Comparison is base (2a4e694) 62.01% compared to head (5b82038) 67.59%.
Report is 82 commits behind head on main.

Files Patch % Lines
contracts/hooks/aggregate/src/lib.rs 0.00% 119 Missing ⚠️
contracts/isms/aggregate/src/lib.rs 0.00% 111 Missing ⚠️
contracts/hooks/routing-custom/src/lib.rs 79.40% 29 Missing and 26 partials ⚠️
packages/connection/src/lib.rs 5.17% 55 Missing ⚠️
contracts/core/mailbox/src/query.rs 54.20% 43 Missing and 6 partials ⚠️
contracts/warp/native/src/contract.rs 73.33% 26 Missing and 22 partials ⚠️
contracts/warp/cw20/src/contract.rs 74.85% 18 Missing and 25 partials ⚠️
contracts/isms/routing/src/contract.rs 37.50% 31 Missing and 9 partials ⚠️
contracts/igps/core/src/query.rs 58.42% 28 Missing and 9 partials ⚠️
contracts/core/va/src/contract.rs 83.17% 18 Missing and 18 partials ⚠️
... and 51 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   62.01%   67.59%   +5.58%     
==========================================
  Files          56       88      +32     
  Lines        1253     5227    +3974     
  Branches        0     5227    +5227     
==========================================
+ Hits          777     3533    +2756     
- Misses        476     1303     +827     
- Partials        0      391     +391

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byeongsu-hong
Copy link
Collaborator

Codecov finally works 😞

@byeongsu-hong byeongsu-hong self-requested a review January 22, 2024 01:20
@byeongsu-hong byeongsu-hong merged commit 32e46b5 into many-things:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot left review comments

@byeongsu-hong byeongsu-hong byeongsu-hong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yorhodes @codecov-commenter @byeongsu-hong @nambrot