You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
boltons have some nice functionality but it would be very handy if it also had type hints. From #318 it seems you are open to type hints, but I just want to confirm this, and check if you have any specific preferences for how they should be added.
From what I gather from the linked issue:
You prefer type hints in .py files (i.e. embedded) as opposed to having them in separate .pyi files
You want validation in CI
Is there any thing more I should consider before working on it?
The text was updated successfully, but these errors were encountered:
Hey Iwan! Thanks for your interest and I'm glad you asked. Actually since going 3.7+, yes, I think the answer here has gotten a lot simpler: Type hints welcome, annotations preferred, no comments / .pyi necessary.
Other than that, I'd request smaller PRs preferred, starting with the functions/types that are least ambiguous to type or that you feel most comfortable typing. :) Also on the docket, if you're typing a signature that involves a **kwargs, feel free to convert it to * kw-only args. :)
boltons have some nice functionality but it would be very handy if it also had type hints. From #318 it seems you are open to type hints, but I just want to confirm this, and check if you have any specific preferences for how they should be added.
From what I gather from the linked issue:
.pyi
filesIs there any thing more I should consider before working on it?
The text was updated successfully, but these errors were encountered: