Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config cache deadlock while trying to load the configuration in the WebPorcessor #1

Open
theCapypara opened this issue Sep 18, 2019 · 2 comments

Comments

@theCapypara
Copy link

The class MageSuite\ExtendedException\Processor\WebProcessor tries to load a configuration value. However this results in a deadlock if the config cache is currently being cleared while a config lock is active. This is the case when magento config:set is being executed for example.
Note how the config:set command will take at least 42 seconds, because this is the default fallback lock timeout.

The reason for this is the logging event in Magento\Framework\Cache\InvalidateLogger, which initializes the WebProcessor, which then tries to load the locked configuration.

As a solution there needs to be a check in WebProcessor which only tries to load the configuration setting when the config lock is not active and otherwise falls back to a fallback value.

@theCapypara
Copy link
Author

theCapypara commented Sep 18, 2019

For reference, here is the entire stacktrace:
stacktrace

The lock occurs at LockedGuardedCacheLoader:113, the logging at InvalidateLogger:46, the loading of configuration is started at WebProcessor:13, and Magento tries to load the locked configuation at LockedGuardedCacheLoader:71

@pinkeen
Copy link
Contributor

pinkeen commented Sep 21, 2019

Hello, thanks for the report. I am not familiar with this particular problem, however, we're aware that this extension causes various problems outside of our internal use-cases. Fortunately it's not required at all for the proper functioning of MageSuite because its only function is to attach additional information to exception logs.

While we look into this, one workaround would be to prevent its installation by adding it to the replace section of composer.json.

Can you take a look at this @diwipl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants