Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Pin internal action usages to the currently released version as opposed to main. #157

Open
damienwebdev opened this issue Sep 28, 2023 · 0 comments
Assignees

Comments

@damienwebdev
Copy link
Member

damienwebdev commented Sep 28, 2023

💡 Feature request

Feature Name

Internal version consistency

The Desired Behavior

When I use https://github.com/mage-os/github-actions/blob/main/fix-magento-install/action.yml#L12 It uses mage-os/github-actions/get-magento-version@main. This should instead be mage-os/github-actions/[email protected] (or whatever the current version is). Then, when we do a PR like #125 it should automatically bump this version.

Your Use Case

Developers really shouldn't be relying on main. It's not supposed to be that stable. We should document the currently leading version, allowing main to be a little less stable.

Prior Work

Release please supports with in .release-please-config.json with extra-files

 {
  ...
  "extra-files": [
    "path/to/file"
  ],
   ...
 }

You simply have to add # x-release-please-version on the line with the version in it.

@damienwebdev damienwebdev self-assigned this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant