Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to remove labels that are greater than maximum duration #4

Open
GabRoyer opened this issue Feb 11, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@GabRoyer
Copy link

GabRoyer commented Feb 11, 2025

Issue

When using DurationPicker in, for example, .minuteSecond mode with a maximumDuration of 180 , the minutes wheel shows numbers past 3 minutes, even though these would never ever be valid.

Proposed Solution

Add another setting, maybe .pruneLabels to optionally remove those excess labels.

Discussion

I really like the component you've built. I'd submit a PR myself, but I really don't know UIKit... That being said, I might contribute a PR for a SwiftUI wrapper very soon (Here it is #5 !).

@mac-gallagher
Copy link
Owner

Thanks @GabRoyer, the initial implementation was just to match UIDatePicker as much as possible, but agree this would make a good addition! Will add this if I find the time, but also leaving it open for other contributors

@mac-gallagher mac-gallagher added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants