Bug in F.maxpool_1d?

[XintianHan]

It seems that there is a bug here

ecg-classification/models/models1d.py

Line 65 in b13236d

identity = F.max_pool1d(identity, self.stride)

F.maxpool_1d takes kernel_size as the second parameter and stride as the third parameter. If you want to specify the stride as it is, it should be something like F.max_pool1d(identity, kernel_size=2, stride=2, padding=1) Otherwise, it may ignore the last dimension of the identity. And this may cause a bug when identity has odd number of dimensions.