From fd753d24c349a27adadd5801515208ded4045407 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Brugarolas?= Date: Tue, 13 Oct 2020 05:07:25 +0200 Subject: [PATCH 1/4] Add TODO.md --- TODO.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 TODO.md diff --git a/TODO.md b/TODO.md new file mode 100644 index 000000000..3c4d4fbdf --- /dev/null +++ b/TODO.md @@ -0,0 +1,8 @@ +# Vuesax clone +Made for solving bugs or improve things that we need in our projects. + +## TODOs: detected bugs or improvements +- Fix button in vsUpload has no type="button" so it causes submit if inside a form: https://github.com/lusaxweb/vuesax/blob/master/src/components/vsUpload/vsUpload.vue#L28. +- VsButton throws an error `Console error: Error in nextTick: “TypeError: Cannot read property ‘clientWidth’ of undefine”` because it triggers on click a `this.$nextTick(callback)` and element may not exist when `callback` is executed (for example, when closing dialogs or navigating between router views): https://github.com/lusaxweb/vuesax/commit/a6506834d90b8b96ece5bcc4554e212277b75318. +- Update dependencies. +- Fix component vsUpload does not work on iOS 13.7 on iPhone 7 (still working on it). From ff24c095b43f0b24eb6829ae85e903253bb61a99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Brugarolas?= Date: Tue, 13 Oct 2020 05:29:06 +0200 Subject: [PATCH 2/4] =?UTF-8?q?VsButton=20fix=20=E2=80=9CTypeError:=20Cann?= =?UTF-8?q?ot=20read=20property=20=E2=80=98clientWidth=E2=80=99=20of=20und?= =?UTF-8?q?efine=E2=80=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/vsButton/vsButton.vue | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/components/vsButton/vsButton.vue b/src/components/vsButton/vsButton.vue index 5dd780a4d..29ee7c114 100644 --- a/src/components/vsButton/vsButton.vue +++ b/src/components/vsButton/vsButton.vue @@ -238,6 +238,10 @@ export default { blurButton(event){ this.$emit('blur',event) this.$nextTick(() => { + if (this._isBeingDestroyed || this._isDestroyed ) { + return + } + if(this.type == 'border' || this.type == 'flat'){ this.opacity = 0 setTimeout( () => { @@ -246,11 +250,14 @@ export default { this.isActive = false } }); - + }, clickButton(event){ this.$emit('click', event) this.$nextTick(() => { + if (this._isBeingDestroyed || this._isDestroyed ) { + return + } if(this.isActive){ return } @@ -301,7 +308,7 @@ export default { }, this.time * 1100) } }); - + }, isColor(){ From 0f64c7fe6054685014da56521fb9d29bcbc2f5bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Brugarolas?= Date: Tue, 13 Oct 2020 05:47:48 +0200 Subject: [PATCH 3/4] Remove unnecesary private file --- TODO.md | 8 -------- 1 file changed, 8 deletions(-) delete mode 100644 TODO.md diff --git a/TODO.md b/TODO.md deleted file mode 100644 index 3c4d4fbdf..000000000 --- a/TODO.md +++ /dev/null @@ -1,8 +0,0 @@ -# Vuesax clone -Made for solving bugs or improve things that we need in our projects. - -## TODOs: detected bugs or improvements -- Fix button in vsUpload has no type="button" so it causes submit if inside a form: https://github.com/lusaxweb/vuesax/blob/master/src/components/vsUpload/vsUpload.vue#L28. -- VsButton throws an error `Console error: Error in nextTick: “TypeError: Cannot read property ‘clientWidth’ of undefine”` because it triggers on click a `this.$nextTick(callback)` and element may not exist when `callback` is executed (for example, when closing dialogs or navigating between router views): https://github.com/lusaxweb/vuesax/commit/a6506834d90b8b96ece5bcc4554e212277b75318. -- Update dependencies. -- Fix component vsUpload does not work on iOS 13.7 on iPhone 7 (still working on it). From 45de4d5022bf97f553489666eda389c8c5925b92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20Brugarolas?= Date: Tue, 13 Oct 2020 05:54:33 +0200 Subject: [PATCH 4/4] Use Vuesax code guidelines --- src/components/vsButton/vsButton.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/vsButton/vsButton.vue b/src/components/vsButton/vsButton.vue index 29ee7c114..f035ebd11 100644 --- a/src/components/vsButton/vsButton.vue +++ b/src/components/vsButton/vsButton.vue @@ -238,7 +238,7 @@ export default { blurButton(event){ this.$emit('blur',event) this.$nextTick(() => { - if (this._isBeingDestroyed || this._isDestroyed ) { + if (this._isBeingDestroyed || this._isDestroyed){ return } @@ -255,7 +255,7 @@ export default { clickButton(event){ this.$emit('click', event) this.$nextTick(() => { - if (this._isBeingDestroyed || this._isDestroyed ) { + if (this._isBeingDestroyed || this._isDestroyed){ return } if(this.isActive){