Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for version 1.2 #1

Closed
llrs opened this issue Sep 15, 2017 · 2 comments
Closed

Improvements for version 1.2 #1

llrs opened this issue Sep 15, 2017 · 2 comments
Assignees
Milestone

Comments

@llrs
Copy link
Owner

llrs commented Sep 15, 2017

List of improvements for the release 1.2

Vignettes

    • Remove wall of text when loading Org.Hs.eg.db via suppressPackageStartupMessages
    • Remove merging similarities explanation in the vignette
    • Call GOSemSim in the vignette instead of comparing with static/hard coded values
    • Make a note to section 9.8 about clashing namespace
    • Remove cluster description in the GOSemSim comparison
    • Section 9.3 move last sentence as a note
    • Correct title of section 9.8 / Check grammar
    • [] Add advanced vignette (currently hosted in here)
      8.1. - [x] Add the packages needed as suggested
      8.2. - [x] Remove section 1.2 but keep the subset of genes
      8.3. - [x] Explain better the implication of the tests.
      8.4. - [x] Compare the similarity within the DE genes and between DE subset and the others
      8.5. - [x] Maybe a plot of one similarity and the other

Package

    • Reduce memory foot print
    • Reduce time for building in Windows
@llrs llrs added this to the Version 1.2 milestone Sep 15, 2017
@llrs llrs self-assigned this Sep 15, 2017
llrs added a commit that referenced this issue Sep 21, 2017
Correct issue #1 1. and improve the test for diceSim
llrs added a commit that referenced this issue Sep 21, 2017
See issue #1 2., remove that section and references pointing there
llrs added a commit that referenced this issue Sep 30, 2017
It covers the issue #1 point 8 and 8.2
llrs added a commit that referenced this issue Sep 30, 2017
@llrs
Copy link
Owner Author

llrs commented Oct 8, 2017

Memory footprint hasn't be reduced (in parallel it stills eats all the memory) This will require use of RCpp or a change in how combineScoresPar works.

@llrs
Copy link
Owner Author

llrs commented Oct 31, 2017

I thought that introducing parallel calculus would reduce memory foot print. Obviously (now) I know it doesn't. I tried addressing some speed and inefficiencies in the code but it wasn't enough to compute the gene similarities for all genes in reactome.db ~ 1041.

Possible steps would be to improve internal memory usage and using Rcpp package and similar packages (and finally learning c++).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant