FindCheck.cmake is not consistent with check.pc

[dernasherbrezon]

FindCheck.cmake has only "check" library:

check/doc/example/cmake/FindCheck.cmake

Line 36 in c5d9592

FIND_LIBRARY( CHECK_LIBRARIES NAMES check )

While check.pc can have "m", "rt", "pthread":

check/CMakeLists.txt

Line 420 in c5d9592

set(LIBS "${LIBS} -lm")

Actually seeing 2 issues here:

1. Linking with the static libcheck is failing. See Building example throws undefined references #156 I guess "m" and "pthread" libraries are actually mandatory.
2. Two places where lib dependencies defined for cmake. Is it possible to drop handcrafted search from FindCheck.cmake and rely only on pkg-config results? Or remove pkg-config from dependencies and rely purely on CMake's find_package?

[mikkoi]

Are you using the newest check version 0.13.0?
If so, you do not need FindCheck.cmake at all. Commit 56c347d contains instructions. They are missing from the example project at the moment.

In general, when working with CMake projects (using one from another) it is better to not use pkg-config. Pkg-config is mostly used when operating with GNU Autotools, or plain makefiles.

[dernasherbrezon]

Got it.

I tried to re-build my project in Ubuntu 18.04. This is LTE Ubuntu and they have only check version 0.10.x

[mikkoi]

Can you download from repo and build yourself?
Just build in your homedir and do not install at all, i.e. just run cmake && make, not make install. CMake will then add the project to the user local package registry: ~/.cmake/packages/check. Then find_package() will find it even without it having been installed.
For the older Check versions, FindPackage is necessary. Sorry.