Add ck_skip() and ck_skip_msg(...) macros [WIP] [DISCUSS] #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbboehr
force-pushed
the
ck-skip
branch
2 times, most recently
from
07c8ca7 to
8d8084b
Compare
* `ck_skip()` aborts the tests and marks it as skipped * `ck_skip_msg(...)` does the same with a custom printf message * `_ck_skip()` is exposed as a symbol
|
I think a skip should not abort the test, unlike an assertion failure. Otherwise, if you run without fork-mode, an earlier skip will prevent all followup tests from running. With assertion failures that is fine, because you better debug the first failure you encounter. For skip, that seems undesirable. Compare to glib's Yes, it means, usually the user would follow up that with an additional return, like I think this would be a good feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ck_skip()aborts the test and marks it as skippedck_skip_msg(...)does the same with a custom printf message_ck_skip()is exposed as a symbolThese are all analogues of
ck_abort(),ck_abort_msg(), and_ck_assert_failed()Since they basically work like
ck_abort(), I decided to use a flagwasskippedinFailMsginstead of adding a new message type.As it is, I'm not including skipped tests in the success percentage, but they are included in total tests run. I considered adding
srunner_ntests_skipped()andsrunner_skipped()but decided to hold off since they are included insrunner_results()In
tr_type_str, I assigned skip toKbecause the default return value wasSalready. I'm not sure if there's a more appropriate value here.I'm personally using check with the autotools tap driver, and it seems to be working alright so far.
Let me know if you have any thoughts and, of course, feel free to request changes.
Closes #178