Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the stats detail quest page - Modify the status of "Ongoing" and "Finished." #1081

Open
Kevils opened this issue Jan 28, 2025 · 8 comments

Comments

@Kevils
Copy link
Collaborator

Kevils commented Jan 28, 2025

Description 📹

Current :
Image

New design :
Image
Image

Figma File :
https://www.figma.com/design/fh0OAvj4AS08kHoSxu3DkE/%F0%9F%9A%80-Starknet-Quest?node-id=6870-5648&t=ZvvWJW4vZ48J0Mi6-1

Modify the status of "Ongoing" and "Finished by adding icons"

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added Good first issue Good for newcomers open for contribution An issue that is available for an Only Dust contribution and removed open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers labels Jan 28, 2025
@dicethedev
Copy link
Contributor

Please can I work on this?

@Crosstons
Copy link

Can I work on this?

@SudiptaPaul-31
Copy link
Contributor

Please assign this issue to me

ETA : 1 Day

@OWK50GA
Copy link
Contributor

OWK50GA commented Feb 7, 2025

Hi, Let me do this

@chiscookeke11
Copy link
Contributor

Could I take on this issue?

@PedroCo3lho
Copy link
Contributor

Can I work on this,
I reviewed the codebase and will implement the new design in app/analytics/[questId]/page.tsx

<Typography type={TEXT_TYPE.BODY_DEFAULT} color="white">
    {questData?.expired ? "Finished" : "Ongoing"}
</Typography>

@Verifieddanny
Copy link

May I take care of this?

@Elite-tch
Copy link
Contributor

I’d like to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants