Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title is typoed with %s #55

Open
1 task
fricoben opened this issue Nov 25, 2024 · 24 comments · Fixed by #56
Open
1 task

Title is typoed with %s #55

fricoben opened this issue Nov 25, 2024 · 24 comments · Fixed by #56
Assignees
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution

Comments

@fricoben
Copy link
Contributor

Description 📹

Title of the app is typoed we need to make the title dynamic.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:

  • Change title to a dynamic one like so on theme.config.tsx
import React from "react";
import { DocsThemeConfig, useConfig } from "nextra-theme-docs";
import HeadComponent from "@components/head";

const config: DocsThemeConfig = {
  logo: <img src="/logo.svg" style={{ height: "60px" }} />,
  project: {
    link: "https://github.com/lfglabs-dev",
  },
  chat: {
    link: "https://discord.gg/KQkPNymrE8",
  },
  docsRepositoryBase: "https://github.com/lfglabs-dev/docs.starknet.id",
  footer: { component: null },
  head: () => {
    const { title } = useConfig()
    return (
      <>
        <HeadComponent />
        <title>{title}</title>
      </>
    )
  },
};

export default config;
  1. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:
    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@fricoben fricoben added Open for contribution An issue that is available for an Only Dust contribution OD Hack Issue reserved for the OD Hack Good first issue Good for newcomers labels Nov 25, 2024
@lauchaves
Copy link

hey! May I work on this one?

@OWK50GA
Copy link

OWK50GA commented Nov 25, 2024

Hi!
I can work on this issue

@Villarley
Copy link
Contributor

Villarley commented Nov 25, 2024

Hey @fricoben 🚀🚀🚀,
I’m Santiago Villarreal Arley, a proactive and communicative developer with experience in both front-end and back-end Web3 development. I’m a proud member of Dojo Coding and have worked on various projects built on StarkNet and Stellar, where I actively contributed to creating scalable and efficient solutions. I also won a Web3 hackathon Buildathon for my work on BuildMyEvent, an open-source blockchain project focused on solving real-world challenges and integrating useful features.

I estimate this will take 2–3 days to complete.

To solve this, I’ll update theme.config.tsx to make the title dynamic, test for functionality, and follow all contribution guidelines. I already contributed to Starknet Quest so I'm familiar with the workflow.
Pls feel free to reach out!

@PedroCo3lho
Copy link

Hello @fricoben, I would love to tackle this one!
I'm a full-stack dev and have previously contributed to the project

@hoangkianh
Copy link
Contributor

hoangkianh commented Nov 25, 2024

I'd like to handle this task. ETA 12 hours

@Birdmannn
Copy link

Hello, @fricoben can I handle this?

@Emmanex01
Copy link

Could I be assigned to this?

@JosueBrenes
Copy link

Hi, I'm Josué Brenes and I'll be working on issue.
I'm Dojo Coding member. ⛩️

I estimate this will take 1 day to complete.

My Plan for Fixing the Dynamic Title Issue

1. Create a Branch

I will fork the repo and create a branch:

git checkout -b fix-[issue-number]

2. Make the Changes

I will update theme.config.tsx to make the title dynamic:

head: () => {
  const { title } = useConfig();
  return (
    <>
      <HeadComponent />
      <title>{title}</title>
    </>
  );
},

3. Test Locally

I will verify the changes work by running:

npm run build
npm run start

4. Commit and Push

Once tested, I’ll commit and push:

git add theme.config.tsx
git commit -m "Fix: Dynamic title"
git push origin fix-[issue-number]

5. Submit PR

I will create a pull request, referencing the issue with:

Close #[issue_id]

6. Review and Finalize

I’ll label the PR as "ready for review," address feedback, and ensure all tests pass.

@emarc99
Copy link

emarc99 commented Nov 25, 2024

Could I take over this issue? Please let me do this.
ETA: 1 day.

@morelucks
Copy link

Hi Typoed

I am Lucky Kamshak, a backend developer with over three years of experience specializing in Node.js, Express.js, and Python/Django. I’d like to contribute to your project by addressing the issue of making the app title dynamic.

My Approach

  1. Dynamic Title Implementation

    • Integrate a backend-driven mechanism (if applicable) to provide a dynamic title, using APIs or configuration management.
    • Implement logic on the frontend to fetch and display the dynamic title seamlessly.
  2. Optimization

    • Optimize the implementation to ensure performance and compatibility with the existing architecture.
  3. Testing

    • Write thorough test cases to validate the solution, ensuring reliability across scenarios.
  • My extensive experience in backend development ensures I can integrate dynamic features while maintaining a clean, efficient codebase.
  • I’ve worked on similar projects where dynamic configurations, including titles and metadata, were implemented using backend services.

I’m excited about the opportunity to contribute to your project and help enhance the app's functionality.

@Benjtalkshow
Copy link

Could I try solving this?

@Thibrac
Copy link

Thibrac commented Nov 25, 2024

Is it okay if I tackle this? I finished the ecole 42 program with a web project, and I'd like to make this exit to contribute to a project and get started! :)
You can have a look at my github with the transcendance project

@emmz3230
Copy link

Is this issue still available?
will create resuable title head

@SudiptaPaul-31
Copy link

Would love to work on this issue

My approach:

First will start by inspecting the codebase and then move to the destination file and will check the typo error and make it dynamic as per requested and at the end testing to check whether its dynamic or not and then eventually end by making a PR.

ETA- 1day

@DotworldX
Copy link

Is this issue still available?

@CEOliam
Copy link

CEOliam commented Nov 25, 2024

I'd love to give this a go.

1 similar comment
@pheobeayo
Copy link

I'd love to give this a go.

@jaykayudo
Copy link

Is it okay if I tackle this?
I am an experienced full stack developer with my frontend stack being React and i can assure you that i will make a clean and quick PR. within a day.
I am new here and i will make sure that i follow all the guideline to the letter when preparing the PR.

@NueloSE
Copy link

NueloSE commented Nov 25, 2024

I'd love to work on this!

@OlgaKush512
Copy link

I'd like to take this issue.

@Jagadeeshftw
Copy link

I would like to work on this issue @fricoben

@mimisavage
Copy link

Is this issue still available?

@Yunusabdul38
Copy link

I’d love to work on this task.

@DioChuks
Copy link
Contributor

Can I handle this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.