Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew your domain - Final review #1030

Closed
3 tasks done
Kevils opened this issue Feb 6, 2025 · 24 comments · Fixed by #1086
Closed
3 tasks done

Renew your domain - Final review #1030

Kevils opened this issue Feb 6, 2025 · 24 comments · Fixed by #1086
Assignees
Labels
Good first issue Good for newcomers OD Build Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Feb 6, 2025

Description 📹

Issues :

Your task will be to check that all the issues have been correctly developed, that the components are properly arranged, and that everything matches exactly as in the Figma design: https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4173-16977&t=YbIJH1MVnSWRjcqB-1

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added Good first issue Good for newcomers OD Build Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution labels Feb 6, 2025
@SudiptaPaul-31
Copy link

Would love to work on this issue

@mimisavage
Copy link

Can I take this issue?

@chiscookeke11
Copy link

Mind if I try this one?

@Verifieddanny
Copy link
Contributor

Would love to tackle this!

2 similar comments
@Verifieddanny
Copy link
Contributor

Would love to tackle this!

@Verifieddanny
Copy link
Contributor

Would love to tackle this!

@Elite-tch
Copy link
Contributor

I’m interested in this one.

@Emmanex01
Copy link
Contributor

Mind if I take this issue?

@pheobeayo
Copy link
Contributor

Let me handle this issue!

@caxtonacollins
Copy link
Contributor

I’d like to resolve this.

@Emmy123222
Copy link

I’m interested in this one.

@Snehagupta1907
Copy link
Contributor

Can I tackle this one?

@covenantebube
Copy link

Hi, My name is covenant ebube. I am a MERN stack developer with years of experience solving problems using Typescript. And i am very confident that i can solve this task. Can you please assign

@wheval
Copy link

wheval commented Feb 6, 2025

I can get this done. Please assign

@emmz3230
Copy link

emmz3230 commented Feb 7, 2025

I will check all the components are arranged in the respected folder expected and the design is well understood and intrepreted using the Figma design.

@kayceeDev
Copy link
Contributor

Hi, my name is Leonard and I am fullstack Javascript/TypeScript developer and a Diamond contributor to the OD community. I build intuitive and pixel-perfect responsive web apps.
With my proficiency in frontend development, I will deliver these issues within 3 days of assignment, My first draft PR will be created within 12 hours of assignment.

I am a first time contributor and I want to be assigned to this.

ETA: 60Hours

@Benjtalkshow
Copy link
Contributor

I’d like to resolve this.

@3th-Enjay
Copy link

Can I handle this task?

@blessingbytes
Copy link
Contributor

I'm ready to tackle this issue

@Kingsuite
Copy link
Contributor

Is it okay if I take this?

@B-uchi
Copy link

B-uchi commented Feb 8, 2025

Can I take care of this issue?

@Marchand-Nicolas
Copy link
Collaborator

Hello @Kingsuite are you working on the issue ?

@Kingsuite
Copy link
Contributor

@Marchand-Nicolas Yes. I am on it

@Marchand-Nicolas
Copy link
Collaborator

@Marchand-Nicolas Yes. I am on it

@Kingsuite Great! Thanks for your answer.
Currently, 2/3 PRs have been merged, so you can't do 100% of your issue, but you can start checking what it not good with the merged PRs (either code not clean enough, or it doesn't render like figma). You can check the responsive, margins, paddings, colors, font size/weight, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Build Issue reserved for the OD Build Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.