Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single segment namespace #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix single segment namespace #79

wants to merge 1 commit into from

Conversation

coldnew
Copy link

@coldnew coldnew commented May 27, 2015

Move to multiple namespace to prevent following warning

WARNING: domina is a single segment namespace at line 1 file:/Users/user/.m2/repository/domina/domina/1.0.3/domina-1.0.3.jar!/domina.cljs

Fixes #77

Signed-off-by: Yen-Chin Lee [email protected]

@coldnew
Fix single segment namespace
65ac87c 
Signed-off-by: Yen-Chin Lee <[email protected]>
@gberenfield
Copy link

Can you please merge this, seems trivial
Thanks!

@karneaud
Copy link

+1 stops reloading from happening please fix!

@a613
Copy link

a613 commented Feb 17, 2017 •
edited
Loading

@ckirkendall FYI

@a613
Copy link

a613 commented Feb 17, 2017

@coldnew What about an upversion? This is certainly a breaking change & a major version bump is appropriate.

@coldnew
Copy link
Author

coldnew commented Mar 5, 2017

@a613 I think version bump is decieded by @levand and that's why I didn't do upversion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to a multi segment namespace
4 participants
@coldnew @gberenfield @karneaud @a613