Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to make a supply ship in the nether due to calling a structure that no themes have. #10636

Open
4 of 5 tasks
skythegguy opened this issue Feb 3, 2025 · 7 comments
Labels
Bug Gotta squash 'em all!

Comments

@skythegguy
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.870-1.21.1-snapshot

Structurize Version

1.0.758-1.21.1-snapshot

Related Mods and their Versions

  1. Neoforge 21.1.115
  2. Domnum ornamentum 1.0.204-1.21.1-snapshot
  3. Multi-piston 1.2.51-1.21.1-snapshot
  4. Towntalk 1.2.0

Current Behavior

When attempting to place a supply ship while in the nether, it will give no preview, and placing the ship will be impossible.
Image
In the log when attempting to place a supply shin in the nether it gives the following error:
Image
No existing themes have this blueprint, which makes it impossible to use a supply ship while in the nether. supply ship functions normally as expected while in the overworld.
Going into the switch pack button also shows no valid themes when attempting to place a supply ship in the nether (works normally for supply camps & structure wand)
Image

Expected Behavior

Able to place supply ships in the nether normally.

Reproduction Steps

  1. Enter nether
  2. Attempt to create supply ship, select style of choosing. Currently no official minecolonies themes have this blueprint so any official style should produce this error, but it was tested on shire, warped, and minecolonies themes.

Logs

https://pastebin.com/jnsry0jb

Anything else?

I was actually able to make a personal bandaid solution to this issue by opening the minecolonies jar and duplicating one of the supply ship blueprint files then renaming it to the one minecolonies called, which seemed to work perfectly fine (the one I created was the only valid option).

I Think what happened here is that on the code end, the Devs decided to add support for nether variants of supply ships (presumably because most ships are wood, and thus not suitable for the nether) but along the way this was not passed to whoever works on the themes side of the mod (or it was ignored in favour of putting work in other areas) leading to there being no valid structures to place when the game tries to call for a ship in the nether.
Maybe a temporary solution to retain this functionality while allowing ships to be used in the nether would be to create some sort of fallback, where if there is no nether ship blueprint included in a pack, it will fallback to the overworld one?

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
@skythegguy skythegguy added the Bug Gotta squash 'em all! label Feb 3, 2025
@Shadizar
Copy link

Shadizar commented Feb 3, 2025

Supply ships aren't required for almost all styles

If a style wants such a ship all they have to do is scan one in specifically for the nether per https://discord.com/channels/139070364159311872/724810019928801290/1269103569584263291

@Shadizar
Copy link

Shadizar commented Feb 3, 2025

I think most styles just don't because they're not normally done in the nether

@skythegguy
Copy link
Author

skythegguy commented Feb 3, 2025

Supply ships aren't required for almost all styles

If a style wants such a ship all they have to do is scan one in specifically for the nether per https://discord.com/channels/139070364159311872/724810019928801290/1269103569584263291

I think most styles just don't because they're not normally done in the nether

The issue then is that there is no official theme supports this feature, effectively making it impossible to use a supply ship in the nether without addons. Zero official themes have a nethership blueprint, even the self-claimed designed for nether play warped theme.

@Talyda
Copy link
Contributor

Talyda commented Feb 3, 2025

Yeah, issue isn't that not all styles have one, but with warped style for example, which DOES have the supply ship, when you try and place it, it freezes everythign up (for me at least) and gives that same error

[08:56:44] [Structurize IO Worker #0/ERROR]: Error loading blueprint: Warped Netherlands:blueprints/minecolonies/warped/decorations/supplies/nethership.blueprint
java.io.FileNotFoundException: null

It's like it is looking for the wrong blueprint, from the warped supply ship? Or some other weirdness. Not sure what, but something is definitely wrong there

@Talyda
Copy link
Contributor

Talyda commented Feb 3, 2025

Supply ships aren't required for almost all styles

If a style wants such a ship all they have to do is scan one in specifically for the nether per https://discord.com/channels/139070364159311872/724810019928801290/1269103569584263291

Oh, sorry, just read what you linked - so probably warped style needs to be rescanned with new name then

@Shadizar
Copy link

Shadizar commented Feb 3, 2025

if so I'd request it also stay too with the old name so it can still be used in the overworld

@Shadizar
Copy link

Shadizar commented Feb 3, 2025

as a note
folks could just copy the warped 'nethership' once scanned, to......all the official styles hehe
it's cheesy but it would work fine and it's not likely to come up very much
at least until / unless someone later wanted to do bespoke specific style netherships for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Gotta squash 'em all!
Projects
None yet
Development

No branches or pull requests

3 participants