-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's impossible to make a supply ship in the nether due to calling a structure that no themes have. #10636
Comments
Supply ships aren't required for almost all styles If a style wants such a ship all they have to do is scan one in specifically for the nether per https://discord.com/channels/139070364159311872/724810019928801290/1269103569584263291 |
I think most styles just don't because they're not normally done in the nether |
The issue then is that there is no official theme supports this feature, effectively making it impossible to use a supply ship in the nether without addons. Zero official themes have a nethership blueprint, even the self-claimed designed for nether play warped theme. |
Yeah, issue isn't that not all styles have one, but with warped style for example, which DOES have the supply ship, when you try and place it, it freezes everythign up (for me at least) and gives that same error
It's like it is looking for the wrong blueprint, from the warped supply ship? Or some other weirdness. Not sure what, but something is definitely wrong there |
Oh, sorry, just read what you linked - so probably warped style needs to be rescanned with new name then |
if so I'd request it also stay too with the old name so it can still be used in the overworld |
as a note |
Is there an existing issue for this?
Are you using the latest MineColonies Version?
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
What were you playing at the time? Were you able to reproduce it in both settings?
Minecraft Version
1.21
MineColonies Version
1.1.870-1.21.1-snapshot
Structurize Version
1.0.758-1.21.1-snapshot
Related Mods and their Versions
Current Behavior
When attempting to place a supply ship while in the nether, it will give no preview, and placing the ship will be impossible.
In the log when attempting to place a supply shin in the nether it gives the following error:
No existing themes have this blueprint, which makes it impossible to use a supply ship while in the nether. supply ship functions normally as expected while in the overworld.
Going into the switch pack button also shows no valid themes when attempting to place a supply ship in the nether (works normally for supply camps & structure wand)
Expected Behavior
Able to place supply ships in the nether normally.
Reproduction Steps
Logs
https://pastebin.com/jnsry0jb
Anything else?
I was actually able to make a personal bandaid solution to this issue by opening the minecolonies jar and duplicating one of the supply ship blueprint files then renaming it to the one minecolonies called, which seemed to work perfectly fine (the one I created was the only valid option).
I Think what happened here is that on the code end, the Devs decided to add support for nether variants of supply ships (presumably because most ships are wood, and thus not suitable for the nether) but along the way this was not passed to whoever works on the themes side of the mod (or it was ignored in favour of putting work in other areas) leading to there being no valid structures to place when the game tries to call for a ship in the nether.
Maybe a temporary solution to retain this functionality while allowing ships to be used in the nether would be to create some sort of fallback, where if there is no nether ship blueprint included in a pack, it will fallback to the overworld one?
Footer
Viewers
The text was updated successfully, but these errors were encountered: