Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to move QueryBuilder logic to trait? To support custom Builders #583

Open
ievgenklymenko opened this issue Mar 6, 2023 · 0 comments

Comments

@ievgenklymenko
Copy link

Hi!

The practic of extending builder through newEloquentBuilder is becoming more and more common.
Package owners and project devs - everybody wants to use their own builders.

But since this package uses full custom QueryBuilder class, it is hard to combine with other custom builders.
If we had all builder logic inside a trait instead, this would save the day.

It sound like not hard to do - neither does it ruin backward compatibility - unless I'm missing something.
There was this old request showing how it can be done (but it is stale now):
#229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant