Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Warning: External link https://badges.layer5.io was detected in a Link component #6172

Closed
leecalcote opened this issue Jan 5, 2025 · 10 comments
Labels
help wanted Extra attention is needed issue/willfix kind/chore Necessary task

Comments

@leecalcote
Copy link
Member

leecalcote commented Jan 5, 2025

Current Behavior

The following warning is emitted when the site is built.

External link https://badges.layer5.io was detected in a Link component. Use the Link component only for internal links. See: https://gatsby.dev/internal-links

Desired Situation

  1. Find all references to badges.layer5.io. Ensure they do not produce a warning.
  2. Ensure that the component handles both internal and external links properly.
  3. Ensure that the component handles both internal and external links properly.

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@leecalcote leecalcote added help wanted Extra attention is needed kind/chore Necessary task issue/willfix labels Jan 5, 2025
@leecalcote leecalcote changed the title Build: External link https://badges.layer5.io was detected in a Link component Build Warning: External link https://badges.layer5.io was detected in a Link component Jan 5, 2025
@Jaishree2310
Copy link

@leecalcote I would like to work on this issue.

@Tharanishwaran
Copy link
Member

Tharanishwaran commented Jan 6, 2025

@leecalcote I tried to reproduce this warning locally but couldn't find this warning. could you help point me to where you're seeing it? Thanks!

@Ajay-singh1
Copy link
Member

@leecalcote We can close this issue now.It has been resolved.

@Jaishree2310
Copy link

@Ajay-singh1 It was assigned to me i was working on this issue

@Jaishree2310
Copy link

@FaheemOnHub Please work on your issue and check whether the problem is already assigned to someone or not

@FaheemOnHub
Copy link
Contributor

@Jaishree2310
Thank you for bringing this to my attention. While working on my assigned issue #6173, I noticed that the second problem was closely related and could be resolved with the same solution. To ensure consistency across the codebase, I addressed both issues in the same PR.

I apologize for not clarifying this earlier, but I felt it was necessary to make these changes together to maintain consistency.

@Jaishree2310
Copy link

@Jaishree2310 Thank you for bringing this to my attention. While working on my assigned issue #6173, I noticed that the second problem was closely related and could be resolved with the same solution. To ensure consistency across the codebase, I addressed both issues in the same PR.

I apologize for not clarifying this earlier, but I felt it was necessary to make these changes together to maintain consistency.

I noticed the same issues that were assigned to you, but I ensured the code was structured in a way that would help you address them easily.

No worries at all—just make sure to take care of this next time. 😊

@Ajay-singh1
Copy link
Member

Ajay-singh1 commented Jan 7, 2025

@FaheemOnHub @Jaishree2310 I cannot replicate this warning on my machine.Can you confirm?

@FaheemOnHub
Copy link
Contributor

@Ajay-singh1 the issue is already solved by the pr #6179 and has been merged

@Ajay-singh1
Copy link
Member

Thanks @Jaishree2310 for taking interest in working on this issue but I think it has been resolved via #6179.In the meantime you can check out another issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed issue/willfix kind/chore Necessary task
Development

No branches or pull requests

5 participants