Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice and wide moves in alg change cube orientation #15

Open
AshleyF opened this issue Aug 20, 2018 · 3 comments · May be fixed by #20
Open

Slice and wide moves in alg change cube orientation #15

AshleyF opened this issue Aug 20, 2018 · 3 comments · May be fixed by #20

Comments

@AshleyF
Copy link

AshleyF commented Aug 20, 2018

For example, alg=U maintains red front/yellow up. However, alg=M U reorients to yellow front/orange up. This then requires adding setupmoves=x to maintain the correct orientation. The same is true of wide moves. Maybe I'm just misunderstanding the correct usage...

@AshleyF
Copy link
Author

AshleyF commented Sep 17, 2018

A better way to phrase the issue: M should not be the same as L' R.

http://jsfiddle.net/AshleyF/2xAVX/106/

<h2>Repro</h2>

<h3>When I hold a cube like this:</h3>
<div class="roofpig"></div>

<h3>... and do an M move, it looks like this:</h3>
<div class="roofpig" data-config="alg=M | setupmoves=x">(x) M</div>

<h3>... not this:</h3>
<div class="roofpig" data-config="alg=M">M</div>

<h3>... which looks like L' R:</h3>
<div class="roofpig" data-config="alg=L' R">L' R</div>

Yes, setupmoves can reorient it, but that's a pain and adds complexity when displaying user-input or machine-generated algs; not just static diagrams.

@jgouly
Copy link

jgouly commented Jan 4, 2019

I'm hitting this same issue I think.

<div class="roofpig" data-config="alg=M' U' M' | colored=UL UR">

This re-orients, and then colours the yellow sticks which are now at DL DR.

@alexfung888
Copy link

I think I can cure it, but I cannot determine whether it is causing any side effects.
Since the repo is not open, I can't make a pull request.
If you want to test my change, do this:
edit the roofpig and three js file
search for the string
this.map=t.start_map(),e&&this.track(e)
there is exactly one occurance.
delete the part after the comma, make it read
this.map=t.start_map()
Seems to me the fix is working fine.

@alexfung888 alexfung888 linked a pull request Feb 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants