Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and update LHDFStore + add open_hdf (like in xw_excel.py) #614

Open
3 tasks
alixdamman opened this issue Apr 6, 2018 · 4 comments
Open
3 tasks

Comments

@alixdamman
Copy link
Collaborator

alixdamman commented Apr 6, 2018

TODO:

  • add open_hdf function
  • implement put(key, value, attrs) method:
     arr = ndtest((3, 3))
     with LHDFStore(filepath) as store:
         store.put(key='arr', value=arr, attrs={'type': 'Array'})
  • update documentation of argument filepath of Axis/Group/LArray.to_hdf to tell it can also be a LHDFStore instance
@alixdamman alixdamman added this to the 0.30 milestone Apr 6, 2018
@alixdamman
Copy link
Collaborator Author

@gdementen feel free to update to update my first comment.

@gdementen
Copy link
Contributor

add open_hdf function

We could also go the other way round and deprecate open_excel. I am unsure about this. I never liked open_excel but maybe this is more intuitive for users??? We should make a poll :)

@gdementen
Copy link
Contributor

The main reason for this issue is that I want to handle the case where users load or save an HDF file object by object (for whatever reason) without opening and closing the file for each object (like what happens when you use to_hdf/read_hdf). Maybe renaming LHDFStore and making it into a Session subclass (eg HDFSession) is the right thing to do. In that case, we will need to also make open_excel return an ExcelSession too. It seems like a good idea now, but this is probably hard to achieve because excel.Sheet objects are not really LArrays. In fact, I think they should be (or some subclass of them like LazyLArray), and their .data field should point to the sheet range. Probably a great thing but huge refactor would be necessary to achieve that.

@alixdamman alixdamman modified the milestones: 0.30, 0.31 Jul 18, 2018
@alixdamman alixdamman modified the milestones: 0.31, 0.32 Apr 9, 2019
@alixdamman alixdamman removed this from the 0.32 milestone Aug 1, 2019
@alixdamman
Copy link
Collaborator Author

See PR #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants