Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible prints credentials to console #289

Open
lexxxel opened this issue Jan 16, 2025 · 4 comments
Open

ansible prints credentials to console #289

lexxxel opened this issue Jan 16, 2025 · 4 comments

Comments

@lexxxel
Copy link
Collaborator

lexxxel commented Jan 16, 2025

Ansible warns about possible leaked passwords, e.g. here:

TASK [lae.proxmox : Configure Proxmox Storage] *************************************************************************************************************************************************************************************************************************************************************************************************************
changed: [myserver] => (item={'name': 'pbs', 'type': 'pbs',  <<<redacted>>>  'password': '  'testpassword', <<<redacted>>>
[WARNING]: Module did not set no_log for password
@rabelmervin
Copy link

Hallo @lexxxel ,
I came across this issue and found it quite interesting. I Would like to contribute ? However, I'm new to ansible any guidance would be appreciated :)

@lae
Copy link
Owner

lae commented Jan 17, 2025

@rabelmervin I would recommend familiarizing yourself with Ansible outside of this role first. The documentation is at https://docs.ansible.com/ansible/latest/getting_started/index.html.

This issue is however more on the module development side of Ansible, for which there's a brief intro at https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html. I believe this would just need some modifications in library/proxmox_storage.py for sensitive fields.

@rabelmervin
Copy link

Sure @lae I'll take a look at ansible

@edv-pi
Copy link
Contributor

edv-pi commented Jan 22, 2025

did you set pve_no_log to true? because that should avoid this warning and also avoids leaking password in log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants