Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GracefulShutdown uses gpioPin=16 also assigned to Relay 5? #3

Open
JTG-IX opened this issue Nov 16, 2021 · 4 comments
Open

GracefulShutdown uses gpioPin=16 also assigned to Relay 5? #3

JTG-IX opened this issue Nov 16, 2021 · 4 comments

Comments

@JTG-IX
Copy link

JTG-IX commented Nov 16, 2021

First of all, many thanks for providing these setup helps!
I was already very happy with the GracefulShutdown in the Venus GUI but now discovered in your code GracefulShutdown.sh that when gpio pin16 is pulled low the same could be triggered. (and a hardwire button makes sense in my case).
This pin however seems (?double) used to control relay 5 already in the gpio_list which may be the reason I cannot get it to work.

I tried modifying the gpio_list and can get gpioPin16 to change from out to in by commenting out relay 5 and adding a 6th input under the digital inputs. After reboot it is also shown as 'in' in /sys/class/gpio/gpio23/direction. It does not seem to work though, when I take gpiopin16 (GPIO23) to ground nothing happens where I expect a gracefulshutdown.

Shutting down via the Venus gui works.

@kwindrem
Copy link
Owner

the shutdown code I had in v3.1 and removed in v3.2 uses GPIO 16 (pin 36) for the input. Relay 5 uses GPIO 23 (pin 16) so there isn't a double use. Pins and GPIO numbers are confusing and I did not help by using the variable "gpioPin" !!!!!

In GracefulShutdown.sh it's really the GPIO NUMBER.

You should not need to add to or change the Venus gpio_list. In fact I chose a GPIO that is NOT used by Venus.

Hope that helps.

@JTG-IX
Copy link
Author

JTG-IX commented Nov 17, 2021

Thanks for your quick reply Kevin, appreciated.
Any reason why you removed it in v3.2?

@JTG-IX JTG-IX closed this as completed Nov 17, 2021
@kwindrem
Copy link
Owner

I removed it because I thought the GUI based shutdown was a better solution that didn't require hardware (a jumper wire). I also didn't want an input pin that could accidentally shut down the PI.

I could add the input back in with an option in the setup menu to install it or not. Comments?

@kwindrem kwindrem reopened this Nov 17, 2021
@JTG-IX
Copy link
Author

JTG-IX commented Nov 17, 2021

I would certainly support having that option in addition so +1 from my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants