-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render a page for each known K8s vulnerability using a content adapter #46623
Comments
Included this as a feature in beta -> GA work as a graduation criteria. /triage accepted |
Some ideas on how to implement this: This repo https://github.com/aquasecurity/vuln-list-k8s is being migrated to k-sigs org: kubernetes/org#4873 as a community owned repo. But for the purposes of discussion let's use the repo in its current location. Step 1: As input to content adapter we get a list of OSV JSON files from Github API: https://api.github.com/repos/aquasecurity/vuln-list-k8s/contents/upstream Sample output:
Step 2: Iterate each file name with absolute path using the key |
Help is welcome @jbiers! |
It's much easier if the machine readable feed is one file, rather than lots. If there are lots of files, we first need a single file with a list of the individual files to pull. We can add the OSV data in a follow-up PR. |
Also, we'd prefer to avoid needing API tokens for GitHub as part of the site build; it adds extra friction for new contributors. |
Shorter URLs are an option too; eg https://k8s.io/security/CVE-2021-25749 can redirect to https://kubernetes.io/example/security/CVE-2021-25749 |
/assign |
The repository with OSV files is now migrated within k8s-sigs org: https://github.com/kubernetes-sigs/cve-feed-osv |
@sftim I have a question regarding the path where the CVE files should be created. Your suggestion was https://kubernetes.io/example/security/CVE-2019-11254, but as I understand currently the examples directory only contains example manifests in the form of yaml files. My question is if it makes semantic sense to have the CVEs in this path and not somewhere like https://kubernetes.io/docs/reference/issues-security/cves/cve-2017-1002101/ or similar. If done this way, we could simply use the layouts currently used in other documentation pages, while in the /examples/ path a new one would have to be created. Let me know if I did not make myself clear enough here 😄 |
Oh, the string The directory you use does not not need to exist in the Git source code. |
If you find you want a new layout, SIG Docs can help out with that. |
@jbiers did you decide on what path you'd like the pages to have? You could pick some actual CVE IDs and document the URL that you'd like them to have, to illustrate the pattern you have in mind. |
Help with this issue is very welcome. |
This is a Feature Request
What would you like to be added
Revise https://kubernetes.io/docs/reference/issues-security/official-cve-feed/ to have a page about each vulnerability, rendered using a content adapter.
Ideally, allow contributors to provide dedicated and specialized content for a subset of vulnerabilities, falling back to auto rendering for the remainder.
For example:
Why is this needed
We can provide permalinks in our comms around vulnerabilities.
Comments
/area web-development
/sig security
We would need to be using Hugo v0.126 or later.
Relevant to kubernetes/sig-security#1
Prompted by #46426 (comment)
The text was updated successfully, but these errors were encountered: