Prow integration test: smoke testing tide #23025

chaodaiG · 2021-07-26T18:10:08Z

What would you like to be added:

Prow integration test deploys prow components in kind cluster, which should be able to be used for smoke testing tide, by deploying tide in kind cluster and checking that tide merges a PR on fake github server.

Why is this needed:

https://kubernetes.slack.com/archives/C09QZ4DQB/p1627313972056200

More Details

Changes Required

Add tide at testimage-push target, so that tide is pushed to localhost:5000 registry
Deploy tide during integration test

test-infra/prow/test/integration/setup-cluster.sh

Line 33 in f9fb6d2

readonly PROW_COMPONENTS="sinker crier hook horologium prow-controller-manager fakeghserver"

, and cleanup tide after integration test

test-infra/prow/test/integration/cleanup.sh

Line 23 in f9fb6d2

readonly PROW_COMPONENTS="sinker crier hook horologium prow-controller-manager fakeghserver"
Add tide deployment yaml at https://github.com/kubernetes/test-infra/tree/master/prow/test/integration/prow/cluster, so that the deployment works. Modifications involve:
- tide_service.yaml and tide_rbac.yaml can be symlinks from https://github.com/kubernetes/test-infra/tree/master/config/prow/cluster.
- tide_deployment.yaml will at least requires changing image registry to localhost:5000 like
  
  test-infra/prow/test/integration/prow/cluster/hook_deployment.yaml
  
  Line 41 in f9fb6d2
  
  image: localhost:5000/hook
  
  .
- github-endpoint should be changed to fakeghserver, which was from https://github.com/kubernetes/test-infra/tree/master/prow/test/integration/fakeghserver.
- --history-uri and --status-path are both GCS paths, which is not preferred for integration tests, they can be changed to local path which is supported
  
  test-infra/prow/io/opener.go
  
  Line 211 in 17297ac
  
  if strings.HasPrefix(path, "/") {
  
  . Need to remember mounting a volume for this purpose.
Existing fake github server only implemented partial github APIs, will need to add APIs that tide uses at https://github.com/kubernetes/test-infra/tree/master/prow/test/integration/fakeghserver

The text was updated successfully, but these errors were encountered:

chaodaiG · 2021-07-26T18:10:23Z

/area prow
/help
cc @YuviGold

YuviGold · 2021-07-26T22:35:31Z

Seems like this was already resolved as part of #22582

chaodaiG · 2021-07-26T22:53:45Z

Seems like this was already resolved as part of #22582

That's correct!

fgimenez · 2021-07-27T13:40:13Z

Seems like this was already resolved as part of #22582

In #22582 tide is deployed to prevent deck from complaining but nothing else, I think that the check for tide merging a PR on fake github server is missing, is that correct?

YuviGold · 2021-07-27T15:26:03Z

Seems like this was already resolved as part of #22582

In #22582 tide is deployed to prevent deck from complaining but nothing else, I think that the check for tide merging a PR on fake github server is missing, is that correct?

Yes, that's correct. We should have tide integration tests as well.

fgimenez · 2021-07-27T15:33:18Z

Yes, that's correct. We should have tide integration tests as well.

Cool thx! @YuviGold I'd love to give it a try, is it ok if I pick it up, or do you want to work on it yourself?

YuviGold · 2021-07-28T05:51:54Z

@fgimenez Let me give it a shot. It will help me understand some internals :)

fgimenez · 2021-07-28T07:52:59Z

/assign @YuviGold
/remove-help

@fgimenez Let me give it a shot. It will help me understand some internals :)

Absolutely! feel free to ping if you have any questions, will try to help if I can :)

spiffxp · 2021-08-09T20:59:43Z

/sig testing

k8s-triage-robot · 2021-11-07T21:00:40Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

YuviGold · 2021-11-11T17:13:18Z

Hey guys,
I started to work on having an integration test to verify tide, but unfortunately got stuck when search queries from tide returned empty from fakeghserver. (although debug prints showed data from fakeghserver is sent back as expected)
The big issues here is the first time the GitHub v4 API (GraphQL) is being tested as part of the integration tests. if someone wanna give a hand or take it from here is more than welcome
WIP can be seen here master...YuviGold:tide-smoke-test

@chaodaiG WDYT maybe we can merge part of it so not all the work will go to waste even if it's not being used?
for example, having the functionality to create pull requests as part of the fakeghserver and also configuring tide with correct deployment variables in order to create tide queries

chaodaiG · 2021-11-11T17:24:19Z

I think it's a good idea to merge the portion that can be used, please make sure leave good comments on this part and link here

Part of kubernetes#23025 solution - Add a new `tide_test.go` integration test module. Currently it just creates a dummy PR and a prowjob that matches it (presubmit type) in a org/repo that tide queries. Tide asks the `fakeghserver` for its status via GitHubv4 API using the `SearchQuery`. - make `tide.searchQuery` public to be used by the integration `fakeghserver` module.

chaodaiG · 2021-11-12T14:53:59Z

/remove-lifecycle stale

k8s-triage-robot · 2022-02-10T15:52:42Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-03-12T16:52:07Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-04-11T17:52:02Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-04-11T17:52:18Z

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chaodaiG added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2021

k8s-ci-robot added area/prow Issues or PRs related to prow help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 26, 2021

k8s-ci-robot assigned YuviGold Jul 28, 2021

k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 28, 2021

chaodaiG mentioned this issue Aug 6, 2021

Write instruction for how to add new prow integration tests #23157

Closed

k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 9, 2021

YuviGold mentioned this issue Sep 20, 2021

REQUEST: New membership for YuviGold kubernetes/org#2986

Closed

7 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2021

YuviGold mentioned this issue Nov 12, 2021

Add tide integration tests infra #24337

Closed

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2022

k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 12, 2022

k8s-ci-robot closed this as completed Apr 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prow integration test: smoke testing tide #23025

Prow integration test: smoke testing tide #23025

chaodaiG commented Jul 26, 2021

chaodaiG commented Jul 26, 2021

YuviGold commented Jul 26, 2021

chaodaiG commented Jul 26, 2021

fgimenez commented Jul 27, 2021

YuviGold commented Jul 27, 2021

fgimenez commented Jul 27, 2021

YuviGold commented Jul 28, 2021

fgimenez commented Jul 28, 2021

spiffxp commented Aug 9, 2021

k8s-triage-robot commented Nov 7, 2021

YuviGold commented Nov 11, 2021 •

edited

Loading

chaodaiG commented Nov 11, 2021

chaodaiG commented Nov 12, 2021

k8s-triage-robot commented Feb 10, 2022

k8s-triage-robot commented Mar 12, 2022

k8s-triage-robot commented Apr 11, 2022

k8s-ci-robot commented Apr 11, 2022

Prow integration test: smoke testing tide #23025

Prow integration test: smoke testing tide #23025

Comments

chaodaiG commented Jul 26, 2021

More Details

Changes Required

chaodaiG commented Jul 26, 2021

YuviGold commented Jul 26, 2021

chaodaiG commented Jul 26, 2021

fgimenez commented Jul 27, 2021

YuviGold commented Jul 27, 2021

fgimenez commented Jul 27, 2021

YuviGold commented Jul 28, 2021

fgimenez commented Jul 28, 2021

spiffxp commented Aug 9, 2021

k8s-triage-robot commented Nov 7, 2021

YuviGold commented Nov 11, 2021 • edited Loading

chaodaiG commented Nov 11, 2021

chaodaiG commented Nov 12, 2021

k8s-triage-robot commented Feb 10, 2022

k8s-triage-robot commented Mar 12, 2022

k8s-triage-robot commented Apr 11, 2022

k8s-ci-robot commented Apr 11, 2022

YuviGold commented Nov 11, 2021 •

edited

Loading