Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between published chart v4.9.0 and the corresponding tags #12654

Open
sdwa0 opened this issue Jan 10, 2025 · 2 comments
Open

Mismatch between published chart v4.9.0 and the corresponding tags #12654

sdwa0 opened this issue Jan 10, 2025 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@sdwa0
Copy link

sdwa0 commented Jan 10, 2025

What happened:

The published ingress-nginx helm chart v4.9.0 doesn't seem to match with the git tags helm-chart-4.9.0 and controller-v1.9.5. The build version logged when the controller starts is f503c4bb5fa7d857ad29e94970eb550c2bc00b7c which is different from the commit that the tags point to.

We realized this when we found OpenTracing working with the published ingress-nginx helm chart v4.9.0, but it is supposed to have been deprecated in that version (30820a5).

What you expected to happen:

The published ingress-nginx helm charts should match with the corresponding git tags.

I don't think the chart v4.9.0 should be republished (if republishing is possible) with the commit the tags point to, because that would potentially break production usages of the chart version. But it will be worthwhile to investigate how that happened and possibly improve the release process to avoid such case.

How to reproduce this issue:

Install and start minikube
https://minikube.sigs.k8s.io/docs/start/

$ minikube start

Install the ingress controller

$ helm install zz ingress-nginx --version 4.9.0 --repo https://kubernetes.github.io/ingress-nginx

Get the running ingress-nginx-controller pod and view its logs.

$ kubectl get pods
NAME                                           READY   STATUS    RESTARTS   AGE
zz-ingress-nginx-controller-766ffbf8dc-nm626   1/1     Running   0          5m52s

$ kubectl logs zz-ingress-nginx-controller-766ffbf8dc-nm626 | head -8
-------------------------------------------------------------------------------
NGINX Ingress controller
  Release:       v1.9.5
  Build:         f503c4bb5fa7d857ad29e94970eb550c2bc00b7c
  Repository:    https://github.com/kubernetes/ingress-nginx
  nginx version: nginx/1.21.6

-------------------------------------------------------------------------------
@sdwa0 sdwa0 added the kind/bug Categorizes issue or PR as related to a bug. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdwa0
Copy link
Author

sdwa0 commented Jan 10, 2025

I checked for charts v4.12.0 and v4.11.4. The Build commit hash logged when the Ingress controller starts is actually the parent commit of the tagged commit, not the tagged commit. Since the tagged commits are just documentation updates, the published chart versions do align with the corresponding tags for those versions, unlike for v4.9.0.

-------------------------------------------------------------------------------
NGINX Ingress controller
  Release:       v1.12.0
  Build:         ba73b2c24d355f1cdcf4b31ef7c5574059f12118
  Repository:    https://github.com/kubernetes/ingress-nginx
  nginx version: nginx/1.25.5

-------------------------------------------------------------------------------
-------------------------------------------------------------------------------
NGINX Ingress controller
  Release:       v1.11.4
  Build:         ba0f2ee37f032c9f11967b74862c60a43ed59b36
  Repository:    https://github.com/kubernetes/ingress-nginx
  nginx version: nginx/1.25.5

-------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

2 participants