Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission controller would check for Domain Label Too Long #10941

Open
marinoborges opened this issue Jan 29, 2024 · 3 comments
Open

Admission controller would check for Domain Label Too Long #10941

marinoborges opened this issue Jan 29, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@marinoborges
Copy link

marinoborges commented Jan 29, 2024

What do you want to happen?

Currently, Ingress resources with Domain Names containing labels equal or longer than 64 characters (which violates RFC 1035 - reference) are successfully validated.

The feature request is to have a lever (preferably that could be turned on/off) to prevent Ingress with Domain Label Too Long to be accepted by the admission controller.

Is there currently another issue associated with this?
No

Does it require a particular kubernetes version?
No

@marinoborges marinoborges added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reganfamor
Copy link

image
what is the problem of this, i have follow the instruction and procedure but this is the output. may i have some help?

Copy link

github-actions bot commented Mar 1, 2024

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants