Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging message for disabled snippets during upgrades. #10901

Open
strongjz opened this issue Jan 22, 2024 · 4 comments
Open

Add logging message for disabled snippets during upgrades. #10901

strongjz opened this issue Jan 22, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@strongjz
Copy link
Member

Add an error or warning in creating an ingress object when controller.allowSnippetAnnotations: false and the ingress object contains snippets.

When upgrading ingress, the admission controller is already run for objects deployed, so the admission controller can not check for snippets again. Logs in the controller should warn users about older objects with snippets enabled and controller.allowSnippetAnnotations: false

/kind bugfix

@strongjz strongjz added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

@strongjz: The label(s) kind/bugfix cannot be applied, because the repository doesn't have them.

In response to this:

Add an error or warning in creating an ingress object when controller.allowSnippetAnnotations: false and the ingress object contains snippets.

When upgrading ingress, the admission controller is already run for objects deployed, so the admission controller can not check for snippets again. Logs in the controller should warn users about older objects with snippets enabled and controller.allowSnippetAnnotations: false

/kind bugfix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jan 22, 2024
@strongjz
Copy link
Member Author

Something similar was asked for but not followed up #7893

Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

2 participants