-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nginx build ci test in release branches #10763
Comments
/backlog important-longterm |
@strongjz: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @strongjz I would like to help here, let me know how can I help. |
hey @strongjz I would like to work on this issue, could you please explain more about that. |
Hey @strongjz , I am trying to understand it and have a question or need a clarification. Do we need to update this workflow file here ingress-nginx/.github/workflows/ci.yaml Line 14 in 27e2652
release-1.8 and release-1.9 so that this workflow also run for those two branches?
|
/assign |
I apologize folks, i opened this one with little details and then went on holiday. @SD-13 you are correct but make it a regex release-* since were going to cut release-1.10 branch soon. |
We need to add the CI test building the nginx image into the release branches for 1.9 and 1.8, till we cut 1.10.
The text was updated successfully, but these errors were encountered: