Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nginx build ci test in release branches #10763

Closed
strongjz opened this issue Dec 15, 2023 · 7 comments · Fixed by #10819
Closed

add nginx build ci test in release branches #10763

strongjz opened this issue Dec 15, 2023 · 7 comments · Fixed by #10819
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@strongjz
Copy link
Member

We need to add the CI test building the nginx image into the release branches for 1.9 and 1.8, till we cut 1.10.

@strongjz strongjz added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Dec 15, 2023
@strongjz
Copy link
Member Author

/backlog important-longterm
/triage accepted
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@strongjz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/backlog important-longterm
/triage accepted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2023
@rodrigodelmonte
Copy link

Hi @strongjz

I would like to help here, let me know how can I help.

@prashantrewar
Copy link

hey @strongjz

I would like to work on this issue, could you please explain more about that.

@SD-13
Copy link
Contributor

SD-13 commented Jan 2, 2024

Hey @strongjz , I am trying to understand it and have a question or need a clarification. Do we need to update this workflow file here

by adding release-1.8 and release-1.9 so that this workflow also run for those two branches?

@SD-13
Copy link
Contributor

SD-13 commented Jan 2, 2024

/assign

@strongjz
Copy link
Member Author

strongjz commented Jan 2, 2024

I apologize folks, i opened this one with little details and then went on holiday.

@SD-13 you are correct but make it a regex release-* since were going to cut release-1.10 branch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants