Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod level securityContext.capabilities reflecting in helm template but not after helm upgrade #10751

Closed
archittsc opened this issue Dec 12, 2023 · 5 comments
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@archittsc
Copy link

I need to configure the pod security context which I did by adding .Values.controller.podSecurityContext as shown below. However even after adding and deploying using helm upgrade, my deployment is not reflecting the changes. Screenshots attached below.

values.yaml file
Screenshot 2023-12-12 at 5 54 27 PM

deployment yaml (live manifest)
Screenshot 2023-12-12 at 6 09 51 PM

How can I make my changes reflect in the actual ingress controller deployment?

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Dec 12, 2023
@strongjz
Copy link
Member

@Gacko will the fix we just put in, fix this?

@Gacko
Copy link
Member

Gacko commented Dec 20, 2023

controller.podSecurityContext goes straight into the .spec.template.securityContext of the Deployment and therefore into the .spec.securityContext of the Pod.

According to API docs, Pods don't have a capabilities field: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#podsecuritycontext-v1-core

This might be the reason why it's not in the live manifest.

@archittsc: Consider setting this in controller.containerSecurityContext. But actually you don't need to do so in the upcoming version of our chart anymore.

@Gacko
Copy link
Member

Gacko commented Dec 20, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@Gacko: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Archived in project
Development

No branches or pull requests

4 participants