Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation needed about server-snippet #10711

Closed
auwaerter opened this issue Dec 1, 2023 · 4 comments
Closed

Confirmation needed about server-snippet #10711

auwaerter opened this issue Dec 1, 2023 · 4 comments
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@auwaerter
Copy link

auwaerter commented Dec 1, 2023

Hello together,

i do not have access to slack so i'm asking here. I'm running nginx-ingress 1.9.4 and i need the confirmation about if #10393 is responsible to prevent the following annotation:

  annotations:
    nginx.ingress.kubernetes.io/server-snippet: |
     return 302 $scheme://en.wikipedia.org/wiki/HTTP_404;

to enable it, i do have to change the value allowSnippetAnnotations to true. Am i correct? E.g. see the documentation.

Thanks a lot! :)

@auwaerter auwaerter added the kind/bug Categorizes issue or PR as related to a bug. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Dec 1, 2023
@longwuyuan
Copy link
Contributor

Yes

/remove-kind bug

You can signup at slack.k8s.io

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 1, 2023
@longwuyuan
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@longwuyuan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Archived in project
Development

No branches or pull requests

3 participants