-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add golangci github action and replace the deprecated golint (#10187)
* Add golangci github action and replace the deprecated golint Signed-off-by: z1cheng <[email protected]> * Install if golangci-lint not exists Signed-off-by: z1cheng <[email protected]> * Use -z operator Signed-off-by: z1cheng <[email protected]> * Fix json tag for DatadogSampleRate field in config.go Signed-off-by: z1cheng <[email protected]> * Add golangci linters Signed-off-by: z1cheng <[email protected]> * Revert DatadogSampleRate fix Signed-off-by: z1cheng <[email protected]> * Fix comments Signed-off-by: z1cheng <[email protected]> * Add a new line Signed-off-by: z1cheng <[email protected]> * fixup! Add a new line Signed-off-by: z1cheng <[email protected]> * Add trigger condition Signed-off-by: z1cheng <[email protected]> * Add golint-check entry in makefile Signed-off-by: Chen Chen <[email protected]> * Run golint-check in a container Signed-off-by: Chen Chen <[email protected]> --------- Signed-off-by: z1cheng <[email protected]> Signed-off-by: Chen Chen <[email protected]>
- Loading branch information
Showing
5 changed files
with
289 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: golangci-lint | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - 'deploy/**' | ||
| - '**.md' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| golangci: | ||
| name: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 | ||
|
|
||
| - name: Set up Go | ||
| id: go | ||
| uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 # v4.0.1 | ||
| with: | ||
| go-version: '1.20' | ||
| check-latest: true | ||
|
|
||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0 | ||
| with: | ||
| version: v1.53 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,241 @@ | ||
| run: | ||
| timeout: 10m | ||
| allow-parallel-runners: true | ||
|
|
||
| # Maximum issues count per one linter. Set to 0 to disable. Default is 50. | ||
| max-issues-per-linter: 0 | ||
|
|
||
| # Maximum count of issues with the same text. Set to 0 to disable. Default is 3. | ||
| max-same-issues: 0 | ||
| linters: | ||
| disable-all: true | ||
| enable: | ||
| - asasalint | ||
| - asciicheck | ||
| - bidichk | ||
| - bodyclose | ||
| - contextcheck | ||
| - decorder | ||
| - dogsled | ||
| - dupl | ||
| - durationcheck | ||
| - errcheck | ||
| - errchkjson | ||
| - errname | ||
| - execinquery | ||
| - ginkgolinter | ||
| - gocheckcompilerdirectives | ||
| - goconst | ||
| - gocritic | ||
| - gocyclo | ||
| - godox | ||
| - gofmt | ||
| - gofumpt | ||
| - goheader | ||
| - goimports | ||
| - gomoddirectives | ||
| - gomodguard | ||
| - goprintffuncname | ||
| - gosec | ||
| - gosimple | ||
| - govet | ||
| - grouper | ||
| - importas | ||
| - ineffassign | ||
| - loggercheck | ||
| - makezero | ||
| - misspell | ||
| - musttag | ||
| - nakedret | ||
| - nolintlint | ||
| - nosprintfhostport | ||
| - prealloc | ||
| - predeclared | ||
| - promlinter | ||
| - reassign | ||
| - revive | ||
| - rowserrcheck | ||
| - sqlclosecheck | ||
| - staticcheck | ||
| - stylecheck | ||
| - tenv | ||
| - testableexamples | ||
| - typecheck | ||
| - unconvert | ||
| - unparam | ||
| - unused | ||
| - usestdlibvars | ||
| - whitespace | ||
| # - containedctx | ||
| # - cyclop | ||
| # - dupword | ||
| # - errorlint | ||
| # - exhaustive | ||
| # - exhaustruct | ||
| # - exportloopref | ||
| # - forbidigo | ||
| # - forcetypeassert | ||
| # - funlen | ||
| # - gci | ||
| # - gochecknoglobals | ||
| # - gochecknoinits | ||
| # - gocognit | ||
| # - godot | ||
| # - goerr113 | ||
| # - gomnd | ||
| # - interfacebloat | ||
| # - ireturn | ||
| # - lll | ||
| # - maintidx | ||
| # - nestif | ||
| # - nilerr | ||
| # - nilnil | ||
| # - nlreturn | ||
| # - noctx | ||
| # - nonamedreturns | ||
| # - paralleltest | ||
| # - tagliatelle | ||
| # - testpackage | ||
| # - thelper | ||
| # - tparallel | ||
| # - varnamelen | ||
| # - wastedassign | ||
| # - wrapcheck | ||
| # - wsl | ||
| linters-settings: | ||
| gocyclo: | ||
| min-complexity: 40 | ||
| godox: | ||
| keywords: | ||
| - BUG | ||
| - FIXME | ||
| - HACK | ||
| errcheck: | ||
| check-type-assertions: true | ||
| check-blank: true | ||
| gocritic: | ||
| enabled-checks: | ||
| # Diagnostic | ||
| - appendAssign | ||
| - argOrder | ||
| - badCall | ||
| - badCond | ||
| - badLock | ||
| - badRegexp | ||
| - badSorting | ||
| - builtinShadowDecl | ||
| - caseOrder | ||
| - codegenComment | ||
| - commentedOutCode | ||
| - deferInLoop | ||
| - deprecatedComment | ||
| - dupArg | ||
| - dupBranchBody | ||
| - dupCase | ||
| - dupSubExpr | ||
| - dynamicFmtString | ||
| - emptyDecl | ||
| - evalOrder | ||
| - exitAfterDefer | ||
| - externalErrorReassign | ||
| - filepathJoin | ||
| - flagDeref | ||
| - flagName | ||
| - mapKey | ||
| - nilValReturn | ||
| - offBy1 | ||
| - regexpPattern | ||
| - returnAfterHttpError | ||
| - sloppyReassign | ||
| - sloppyTypeAssert | ||
| - sortSlice | ||
| - sprintfQuotedString | ||
| - sqlQuery | ||
| - syncMapLoadAndDelete | ||
| - truncateCmp | ||
| - unnecessaryDefer | ||
| - weakCond | ||
|
|
||
| # Performance | ||
| - appendCombine | ||
| - equalFold | ||
| - hugeParam | ||
| - indexAlloc | ||
| - preferDecodeRune | ||
| - preferFprint | ||
| - preferStringWriter | ||
| - preferWriteByte | ||
| - rangeExprCopy | ||
| - rangeValCopy | ||
| - sliceClear | ||
| - stringXbytes | ||
|
|
||
| # Style | ||
| - assignOp | ||
| - boolExprSimplify | ||
| - captLocal | ||
| - commentFormatting | ||
| - commentedOutImport | ||
| - defaultCaseOrder | ||
| - deferUnlambda | ||
| - docStub | ||
| - dupImport | ||
| - elseif | ||
| - emptyFallthrough | ||
| - emptyStringTest | ||
| - exposedSyncMutex | ||
| - hexLiteral | ||
| - httpNoBody | ||
| - ifElseChain | ||
| - methodExprCall | ||
| - newDeref | ||
| - octalLiteral | ||
| - preferFilepathJoin | ||
| - redundantSprint | ||
| - regexpMust | ||
| - regexpSimplify | ||
| - ruleguard | ||
| - singleCaseSwitch | ||
| - sloppyLen | ||
| - stringConcatSimplify | ||
| - stringsCompare | ||
| - switchTrue | ||
| - timeCmpSimplify | ||
| - timeExprSimplify | ||
| - todoCommentWithoutDetail | ||
| - tooManyResultsChecker | ||
| - typeAssertChain | ||
| - typeDefFirst | ||
| - typeSwitchVar | ||
| - underef | ||
| - unlabelStmt | ||
| - unlambda | ||
| - unslice | ||
| - valSwap | ||
| - whyNoLint | ||
| - wrapperFunc | ||
| - yodaStyleExpr | ||
|
|
||
| # Opinionated | ||
| - builtinShadow | ||
| - importShadow | ||
| - initClause | ||
| - nestingReduce | ||
| - paramTypeCombine | ||
| - ptrToRefParam | ||
| - typeUnparen | ||
| - unnamedResult | ||
| - unnecessaryBlock | ||
| nolintlint: | ||
| # Enable to ensure that nolint directives are all used. Default is true. | ||
| allow-unused: false | ||
| # Disable to ensure that nolint directives don't have a leading space. Default is true. | ||
| # TODO(lint): Enforce machine-readable `nolint` directives | ||
| allow-leading-space: true | ||
| # Exclude following linters from requiring an explanation. Default is []. | ||
| allow-no-explanation: [] | ||
| # Enable to require an explanation of nonzero length after each nolint directive. Default is false. | ||
| # TODO(lint): Enforce explanations for `nolint` directives | ||
| require-explanation: false | ||
| # Enable to require nolint directives to mention the specific linter being suppressed. Default is false. | ||
| require-specific: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters