From 6ca7488ff6657befa9151cda83c6d181b5a16d8a Mon Sep 17 00:00:00 2001 From: Bastien Wermeille Date: Tue, 7 Jan 2025 15:22:17 +0100 Subject: [PATCH] Change oauth redirect to 307 --- rootfs/etc/nginx/template/nginx.tmpl | 2 +- test/e2e/annotations/auth.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rootfs/etc/nginx/template/nginx.tmpl b/rootfs/etc/nginx/template/nginx.tmpl index 6b8e750b06..e314569804 100644 --- a/rootfs/etc/nginx/template/nginx.tmpl +++ b/rootfs/etc/nginx/template/nginx.tmpl @@ -1104,7 +1104,7 @@ stream { modsecurity off; {{ end }} - return 302 {{ buildAuthSignURL $externalAuth.SigninURL $externalAuth.SigninURLRedirectParam }}; + return 307 {{ buildAuthSignURL $externalAuth.SigninURL $externalAuth.SigninURLRedirectParam }}; } {{ end }} {{ end }} diff --git a/test/e2e/annotations/auth.go b/test/e2e/annotations/auth.go index ddda1dce5f..a03bf9cdf9 100644 --- a/test/e2e/annotations/auth.go +++ b/test/e2e/annotations/auth.go @@ -494,7 +494,7 @@ http { WithQuery("a", "b"). WithQuery("c", "d"). Expect(). - Status(http.StatusFound). + Status(http.StatusTemporaryRedirect). Header("Location").Equal(fmt.Sprintf("http://%s/auth/start?rd=http://%s%s", host, host, url.QueryEscape("/?a=b&c=d"))) }) @@ -714,7 +714,7 @@ http { WithQuery("a", "b"). WithQuery("c", "d"). Expect(). - Status(http.StatusFound). + Status(http.StatusTemporaryRedirect). Header("Location").Equal(fmt.Sprintf("http://%s/auth/start?orig=http://%s%s", host, host, url.QueryEscape("/?a=b&c=d"))) }) @@ -861,7 +861,7 @@ http { WithQuery("a", "b"). WithQuery("c", "d"). Expect(). - Status(http.StatusFound). + Status(http.StatusTemporaryRedirect). Header("Location").Equal(fmt.Sprintf("http://%s/auth/start?rd=http://%s%s", thisHost, thisHost, url.QueryEscape("/?a=b&c=d"))) }) })