Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using prometheus as metrics provider #8665

Open
Jack-Kingdom opened this issue Feb 2, 2024 · 13 comments
Open

Using prometheus as metrics provider #8665

Jack-Kingdom opened this issue Feb 2, 2024 · 13 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Jack-Kingdom
Copy link

What would you like to be added?

support using prometheus metrics info as metrics source.

Why is this needed?

metrics-scraper store metrics info for provide, and prometheus did this job too. We have no need store those data twice.

@Jack-Kingdom Jack-Kingdom added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 1, 2024
@Jack-Kingdom
Copy link
Author

/remove-lifecycle stale

@Jack-Kingdom
Copy link
Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 10, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 8, 2024
@Jack-Kingdom
Copy link
Author

/remove-lifecycle rotten

@Jack-Kingdom
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2024
@avanish23
Copy link
Contributor

Hi @Jack-Kingdom
The ask seems to be able to disable the default metrics scraper that comes with the dashboard as you already have Prometheus collecting them for you.
Is my understanding right?

@Jack-Kingdom
Copy link
Author

Yeah, I mean, we can disable the default metrics scraper and use prometheus as metrics source.

@floreks
Copy link
Member

floreks commented Oct 29, 2024

If I understand correctly you would want dashboard to support prometheus as data source and display its' metrics directly in the UI?

@Jack-Kingdom
Copy link
Author

@floreks Right!

I found we use sqlite as storage in metrics scraper. Use relation-based db as time seriesed db is not a good idea, this may cause performance issues in large scale k8s.

we can make metrics scraper as a adapter layer to support different metrics source. In my mind, most of k8s deployment have their own metrics system.

@floreks
Copy link
Member

floreks commented Nov 2, 2024

Supporting other data sources is on our list for sure. Victoria metrics/prometheus would be first.

Metrics scraper can't really be compared to them since it is designed to scrape only basic metrics and for a very short time. Normally it only stores the last 15 minutes to visualize current usage and short time peaks. It also scrapes only from metrics server, where i.e. prometheus has its own node-level scraper. For what it is being used is totally fine.

@avanish23
Copy link
Contributor

Oh great, I now understand the ask.
I will take this up and start working on it as I find more bandwidth.
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants