Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support OpenBao as a spec.provider in secrets-store.csi.x-k8s.io/v1 #1580

Open
jessebot opened this issue Jul 23, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jessebot
Copy link

Describe the solution you'd like

I'd like to propose we please add support for OpenBao as a spec.provider.

Anything else you would like to add

OpenBao, a fork of Vault before the license change to BSL, is a Linux Foundation Project and is being actively maintained by a set of kind maintainers and collaborators. We recently forked the Vault CSI Provider repo and started testing it, but I ran into an issue where OpenBao is not recognized as a valid provider, and so I opened this issue to track it: openbao/openbao-csi-provider#5

We're happy to support this effort by submitting PRs to accommodate this. As I'm personally a little new to this repo, if you could point me in the right direction, I am happy to start on a draft PR :) Most everything should be the same as Vault for now, but with the name OpenBao as essentially an alias.

Let me know if you have follow up questions! Happy to help/collaborate 🙏

Environment

  • Secrets Store CSI Driver version: (use the image tag):
    We're actually using the helm chart in our tests and that's using 1.3.2, which I believe also installs the same image tag according to the appVersion in Chart.yaml.

  • Kubernetes version: (use kubectl version):

    Client Version: v1.30.2
    Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
    Server Version: v1.30.2+k3s1
@aramase
Copy link
Member

aramase commented Jul 24, 2024

Hello 👋🏻

Thanks for reaching out and welcome to the community!

There are no changes required in the driver to support a provider. As long as the provider implements the RPC required for communication between driver-provider it should work.

In terms of getting the provider added to the supported provider list here, these are the steps you would need to follow: https://secrets-store-csi-driver.sigs.k8s.io/providers. We would be happy to work with you!

Feel free to reach out on slack if you have any questions.

@aramase
Copy link
Member

aramase commented Oct 15, 2024

@jessebot Any update on this? Let us know how we can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants