Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Synced kubernetes native secret as well after a pod restart #1566

Open
navapias opened this issue Jul 1, 2024 · 3 comments
Open

Update Synced kubernetes native secret as well after a pod restart #1566

navapias opened this issue Jul 1, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@navapias
Copy link

navapias commented Jul 1, 2024

Describe the solution you'd like
Currently when a pod is restarted the secret value in the volume mounts inside the pod get updated, but the synced native secret does not get updated. The code shows only a create a option for the native secret and there is no update. Each time the synced native secret needs to be updated, it needs to be deleted before the pod restart. A solution is required to update the synced secret as well after the pod restart.

Anything else you would like to add:
There is no else condition here,
https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/controllers/secretproviderclasspodstatus_controller.go#L312
Is this an intended behavior since the controller will not be able to find out accurately as to who/which system created this secret if it already exists?

Environment:

  • Secrets Store CSI Driver version: 1.4.4
  • Kubernetes version: 1.27
@navapias navapias added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 1, 2024
@srreddy2020
Copy link

I also Observed the same behavior.
When Secrets are updated at Aws Secrets manger, if we restart the deployment Secrets are not updating in k8s secret.
we need to delete k8s secret first then if we restart the deployment, its creating the new secret with new secret from Aws secrets manger.

Do we have any solution for this.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants